Make work flow files more readable #2808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillco
reviewed
Feb 1, 2025
Comment on lines
+39
to
40
| run: pnpm --color --filter '!cursorless-org' --filter '!cursorless-org-*' build | ||
| env: |
There was a problem hiding this comment.
It makes sense to run compile separately if we think it's faster / higher signal/ROI to read. There's some question about whether build would do everything necessary if compile was skipped, which is a bit concerning, but we did not test this.
phillco
reviewed
Feb 1, 2025
Comment on lines
+48
to
+52
| - name: Run pre-commit hooks | ||
| uses: pre-commit/[email protected] | ||
|
|
||
| - name: Auto-fix pre-commit issues | ||
| uses: pre-commit-ci/[email protected] |
There was a problem hiding this comment.
Open questions: why do we run both the lite sweet and the normal one? Why if: always()?
For the former guessing that the normal suite doesn't automatically correct issues but we have some tests that can't run in it.
phillco
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2796
Release notes