Make work flow files more readable #2808
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,26 +13,40 @@ jobs: | |
| environment: production | ||
| env: | ||
| CURSORLESS_REPO_ROOT: ${{ github.workspace }} | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Enable Corepack | ||
| run: corepack enable | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: pnpm | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm --color install | ||
|
|
||
| - name: Compile | ||
| run: pnpm --color compile | ||
|
|
||
| - name: Build | ||
| run: pnpm --color --filter '!cursorless-org' --filter '!cursorless-org-*' build | ||
| env: | ||
| CURSORLESS_DEPLOY: true | ||
|
|
||
| - name: Publish to Open VSX Registry | ||
| id: publishToOpenVSX | ||
| uses: HaaLeo/publish-vscode-extension@v1 | ||
| with: | ||
| pat: ${{ secrets.OPEN_VSX_TOKEN }} | ||
| packagePath: packages/cursorless-vscode/dist | ||
|
|
||
| - name: Publish to Visual Studio Marketplace | ||
| uses: HaaLeo/publish-vscode-extension@v1 | ||
| with: | ||
|
|
@@ -47,36 +61,53 @@ jobs: | |
| env: | ||
| CURSORLESS_REPO_ROOT: ${{ github.workspace }} | ||
| STAGING_DIRECTORY: ${{ github.workspace }}/cursorless.nvim-staging | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Enable Corepack | ||
| run: corepack enable | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: pnpm | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm --color install | ||
|
|
||
| - name: Compile | ||
| run: pnpm --color compile | ||
|
|
||
| - name: Build | ||
| run: pnpm --color --filter '!cursorless-org' --filter '!cursorless-org-*' build | ||
| env: | ||
| CURSORLESS_DEPLOY: true | ||
|
|
||
| - name: Checkout cursorless.nvim plugin repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| token: ${{ secrets.CURSORLESS_BOT_TOKEN }} | ||
| repository: hands-free-vim/cursorless.nvim | ||
| path: ${{ env.STAGING_DIRECTORY }} | ||
|
|
||
| - name: Configure GPG Key | ||
| working-directory: ${{ env.STAGING_DIRECTORY }} | ||
| run: | | ||
| echo -n "$GPG_SIGNING_KEY" | base64 --decode | gpg --import | ||
| env: | ||
| GPG_SIGNING_KEY: ${{ secrets.CURSORLESS_BOT_GPG_SIGNING_KEY }} | ||
|
|
||
| - name: git config | ||
| working-directory: ${{ env.STAGING_DIRECTORY }} | ||
| run: | | ||
| git config user.name cursorless-bot | ||
| git config user.email [email protected] | ||
| git config user.signingkey A9387720AFC62221 | ||
| git config commit.gpgsign true | ||
|
|
||
| - name: Push compiled files to cursorless.nvim plugin repo | ||
| run: bash -x scripts/deploy-cursorless-nvim.sh ${{ env.STAGING_DIRECTORY }} | ||
|
|
||
|
|
@@ -85,20 +116,26 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| needs: publish-extension | ||
| environment: production | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| token: ${{ secrets.CURSORLESS_BOT_TOKEN }} | ||
|
|
||
| - name: Configure GPG Key | ||
| run: | | ||
| echo -n "$GPG_SIGNING_KEY" | base64 --decode | gpg --import | ||
| env: | ||
| GPG_SIGNING_KEY: ${{ secrets.CURSORLESS_BOT_GPG_SIGNING_KEY }} | ||
|
|
||
| - name: git config | ||
| run: | | ||
| git config user.name cursorless-bot | ||
| git config user.email [email protected] | ||
| git config user.signingkey A9387720AFC62221 | ||
| git config commit.gpgsign true | ||
|
|
||
| - name: Push cursorless-talon subrepo | ||
| run: bash -x scripts/deploy-cursorless-talon.sh | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| name: Pre-commit | ||
| permissions: read-all | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
|
|
@@ -16,19 +17,37 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| env: | ||
| CURSORLESS_REPO_ROOT: ${{ github.workspace }} | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: 3.x | ||
|
|
||
| - name: Enable Corepack | ||
| run: corepack enable | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: pnpm | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm --color install | ||
|
|
||
| - name: Install lua | ||
| uses: leafo/gh-actions-lua@v9 | ||
|
|
||
| - name: Install luarocks | ||
| uses: leafo/gh-actions-luarocks@v4 | ||
|
|
||
| - name: Run pre-commit hooks | ||
| uses: pre-commit/[email protected] | ||
|
|
||
| - name: Auto-fix pre-commit issues | ||
| uses: pre-commit-ci/[email protected] | ||
|
Comment on lines
+48
to
+52
There was a problem hiding this comment. Open questions: why do we run both the lite sweet and the normal one? Why For the former guessing that the normal suite doesn't automatically correct issues but we have some tests that can't run in it. |
||
| if: always() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2391
It makes sense to run compile separately if we think it's faster / higher signal/ROI to read. There's some question about whether
buildwould do everything necessary if compile was skipped, which is a bit concerning, but we did not test this.