Pin vscode version in CI for windows #2901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasArvidsson
changed the title
AndreasArvidsson
changed the title
This was referenced Apr 22, 2025
AndreasArvidsson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had already pinned the version for mac and Linux: #2878 but it appears that we have the same problem on windows its just crashing with error code 0 which means our test runner wasn't signalling the failure.
Test run crashes on windows with false negative.
https://github.com/cursorless-dev/cursorless/actions/runs/14509376075/job/40704611423?pr=2893
It appears that it's
vscode.window.showTextDocumentin ouropenNewEditorutility that causes this. It's not always on the same test case. By default it crashes in the scope tests, but if I disable the scope test the same error occurs in our recorded tests that of course uses the sameopenNewEditorfunction. I can't recreate this locally. Looks like a memory leak or similar.