Skip to content

Pin vscode version in CI for windows #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025
Merged

Pin vscode version in CI for windows #2901

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d41c325
Use latest stable vscode for windows CI tests
AndreasArvidsson Apr 22, 2025
e8c3f16
pin all platforms
AndreasArvidsson Apr 22, 2025
3a110a2
Restore comment
AndreasArvidsson Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/test-harness/src/launchVscodeAndRunTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,7 @@ export async function launchVscodeAndRunTests(extensionTestsPath: string) {
// NB: Because of a CI crashing issue the vscode version is pinned.
// https://github.com/cursorless-dev/cursorless/issues/2878

const vscodeVersion = useLegacyVscode
? "1.82.0"
: os.platform() === "win32"
? "stable"
: "1.97.2";
const vscodeVersion = useLegacyVscode ? "1.82.0" : "1.97.2";
const vscodeExecutablePath = await downloadAndUnzipVSCode(vscodeVersion);
const [cli, ...args] =
resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath);
Expand Down
Loading