Skip to content

chore: even name update#667

Merged
Shahroz16 merged 1 commit intofeat/real-time-locationfrom
update-location-event-name
Mar 9, 2026
Merged

chore: even name update#667
Shahroz16 merged 1 commit intofeat/real-time-locationfrom
update-location-event-name

Conversation

@Shahroz16
Copy link
Contributor

@Shahroz16 Shahroz16 commented Mar 6, 2026

Note

Medium Risk
Changing the emitted track event name is potentially breaking for customers relying on the previous "Location Update" name in journeys/segments and analytics dashboards. No functional logic changes beyond the renamed event string and related docs/comments.

Overview
Updates EventNames.LOCATION_UPDATE from "Location Update" to "CIO Location Update", which changes the name used for the location module’s track events.

Aligns location module documentation/comments (LocationTracker, ModuleLocation) to reference the new event name.

Written by Cursor Bugbot for commit 9db40e3. This will update automatically on new commits. Configure here.

@Shahroz16 Shahroz16 requested a review from a team as a code owner March 6, 2026 20:09
@Shahroz16 Shahroz16 self-assigned this Mar 6, 2026
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.00%. Comparing base (88b1971) to head (9db40e3).
⚠️ Report is 1 commits behind head on feat/real-time-location.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             feat/real-time-location     #667   +/-   ##
==========================================================
  Coverage                      68.00%   68.00%           
  Complexity                       842      842           
==========================================================
  Files                            153      153           
  Lines                           4679     4679           
  Branches                         637      637           
==========================================================
  Hits                            3182     3182           
  Misses                          1259     1259           
  Partials                         238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Build available to test
Version: update-location-event-name-SNAPSHOT
Repository: https://central.sonatype.com/repository/maven-snapshots/

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

  • java_layout: update-location-event-name (1772827816)

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

📏 SDK Binary Size Comparison Report

Module Last Recorded Size Current Size Change in Size
core 31.29 KB 31.27 KB ⬇️ -0.02KB
datapipelines 40.57 KB 40.57 KB ✅ No Change
messagingpush 30.25 KB 30.25 KB ✅ No Change
messaginginapp 121.84 KB 121.84 KB ✅ No Change
tracking-migration 22.89 KB 22.89 KB ✅ No Change

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

  • kotlin_compose: update-location-event-name (1772827802)


// Event name for location updates tracked by the Location module
const val LOCATION_UPDATE = "Location Update"
const val LOCATION_UPDATE = "CIO Location Update"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are tests using the same constants? Shouldn't tests refer to hardcoded values or different constants so they don't rely on same source and can catch if the name is changed unintentionally?

@Shahroz16 Shahroz16 merged commit 0616b22 into feat/real-time-location Mar 9, 2026
38 checks passed
@Shahroz16 Shahroz16 deleted the update-location-event-name branch March 9, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants