Skip to content

chore: even name update #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shahroz16 merged 1 commit into from
Mar 9, 2026
+4 −4
Merged

chore: even name update #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/kotlin/io/customer/sdk/util/EventNames.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ object EventNames {
const val APPLICATION_BACKGROUNDED = "Application Backgrounded"

// Event name for location updates tracked by the Location module
const val LOCATION_UPDATE = "Location Update"
const val LOCATION_UPDATE = "CIO Location Update"
Copy link
Contributor

@mrehan27 mrehan27 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are tests using the same constants? Shouldn't tests refer to hardcoded values or different constants so they don't rely on same source and can catch if the name is changed unintentionally?

}
4 changes: 2 additions & 2 deletions location/src/main/kotlin/io/customer/location/LocationTracker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import java.lang.ref.WeakReference
* location coordinates. This is unfiltered — a new user always gets
* the device's current location on their profile immediately.
*
* 2. **"Location Update" track event** — sent via [DataPipeline.track].
* 2. **"CIO Location Update" track event** — sent via [DataPipeline.track].
* Gated by a userId check and a sync filter (24h / 1km threshold)
* to avoid redundant events. This creates a discrete event in the
* user's activity timeline for journey/segment triggers.
Expand Down Expand Up @@ -99,7 +99,7 @@ internal class LocationTracker(
*
* The identify event itself already carries location via
* [getIdentifyContext] — this method handles the supplementary
* "Location Update" track event, subject to the sync filter.
* "CIO Location Update" track event, subject to the sync filter.
*/
fun onUserIdentified() {
syncCachedLocationIfNeeded()
Expand Down
2 changes: 1 addition & 1 deletion location/src/main/kotlin/io/customer/location/ModuleLocation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ class ModuleLocation @JvmOverloads constructor(
// the primary way location reaches a user's profile.
SDKComponent.identifyHookRegistry.register(locationTracker)

// On identify, attempt to send a supplementary "Location Update" track event.
// On identify, attempt to send a supplementary "CIO Location Update" track event.
// The identify event itself already carries location via context enrichment —
// this track event is for journey/segment triggers in the user's timeline.
eventBus.subscribe<Event.UserChangedEvent> {
Expand Down
Loading