Security context #88
Merged
Security context #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eadOnlyRootFilesystem-parameter
…m True - exporter changed to ReadOnlyRootFilesystem=true
ants
reviewed
Oct 9, 2025
pkg/cluster/k8sres.go
Outdated
| FailureThreshold: 6, | ||
| ProbeHandler: v1.ProbeHandler{ | ||
| HTTPGet: &v1.HTTPGetAction{ | ||
| Path: "/health", |
Collaborator
There was a problem hiding this comment.
The correct endpoint is /liveness. This checks that Patroni is working, but ignores postgres. Checking /health will break during maintenance mode, upgrade and if starting postgres takes too long.
ants
reviewed
Oct 9, 2025
pkg/cluster/k8sres.go
Outdated
| // }, | ||
| // TargetContainers: []string{"postgres-exporter"}, | ||
| // }) | ||
| // } |
Collaborator
There was a problem hiding this comment.
addEmptyDirVolume() handles this, so this can be cleaned up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for SecurityContext modifications.
Step 1 included here: postgres-exporter sidecar, initcontainer and backup-job-container ready for ReadOnlyRootFilesystem: true
Modifications for postgres-pod and pgbackrest-repo host will follow in step 2 including cleanup and removing compatibility-code