Add Cylc Review (from Cylc 7) by wxtim · Pull Request #755 · cylc/cylc-uiserver

wxtim · 2025-11-26T15:52:34Z

Closes cylc/cylc-flow#5937 and cylc/cylc-flow#3441
Requires cylc/cylc-flow#7068 to work correctly (else cylc review is labelled a dead-end).

Sort of requires cylc/release-actions#136 To run coverage later.

Check List

I have read CONTRIBUTING.md and added my name as a Code Contributor.
Contains logically grouped changes (else tidy your branch by rebase).
Does not contain off-topic changes (use other PRs for other changes).
Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
Tests are included (or explain why tests are not needed).

Test working can be demonstrated by adding this to CI.

          pip uninstall cylc-flow -y
          pip install git+https://github.com/wxtim/cylc@feat.cylc-review

https://github.com/cylc/cylc-uiserver/actions/runs/19763672460/job/56631293468

Changelog entry included if this is a change that can affect users
Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

ChrisPaulBennett · 2025-12-08T09:23:04Z

I just had a look at the macOS failures to see I could offer any help........Ooooof.
I'm starting to think that supporting macOS really isn't worth it....

wxtim · 2025-12-08T12:40:50Z

Tests will fail until other branches merged - this commit's tests shows that they should pass after those are merged.

ChrisPaulBennett

Something is not right with the sorting of `last active time`. It appears to be backwards

oliver-sanders · 2026-02-02T16:58:53Z

I just had a look at the macOS failures to see I could offer any help........Ooooof.
I'm starting to think that supporting macOS really isn't worth it....

The Mac OS test failure appears to be the same as the Ubuntu failure.

@wxtim, tests unhappy :(

oliver-sanders

LGTM

.github/workflows/test.yml

cylc/uiserver/jupyter_config.py

cylc/uiserver/review.py

oliver-sanders · 2026-02-02T17:22:52Z

cylc/uiserver/ws.py

+
+
+def get_review_service_config(
+    port: Annotated[int, Ge(0)] = 8042,


tests/functional/cylc-review/05-cycles-job-fails/suite.rc

tests/functional/cylc-review/12-cycle-counts.t

tests/integration/test_cylc_review.py

wxtim · 2026-02-03T09:41:57Z

@wxtim, tests unhappy :(

The tests cannot possibly be happy until cylc/cylc-flow#7068 is merged.

The bodge in cf0fa29 shows that the tests will pass once cylc/cylc-flow#7068 is merged (https://github.com/cylc/cylc-uiserver/actions/runs/21626594723)

fix sort order fixed small bug in broadcast states qurey fix test Remove lint from tests Update tests/functional/cylc-review/05-cycles-job-fails/suite.rc Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk> Update tests/functional/cylc-review/12-cycle-counts.t Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk> Modify comment set local platform use python subproc for testing Turn off cylc review by default with Cylc hub, and turn on how to document it.

…c-flow#7068 merged

wxtim · 2026-02-04T14:23:13Z

All tests passed at 493ecad. Tests cannot pass with 493ecad before cylc/cylc-flow#7068 is merged.

wxtim · 2026-02-17T14:02:44Z

@oliver-sanders - tests should now be failing in the expected manner, and hopefully unicode funsies should be safer.

.github/workflows/test.yml

wxtim marked this pull request as draft November 26, 2025 15:52

wxtim mentioned this pull request Nov 28, 2025

Feat.cylc review cylc/cylc-flow#7068

Open

8 tasks

wxtim force-pushed the feat.cylc-review branch 5 times, most recently from befa4f2 to f35b60c Compare December 4, 2025 10:19

basic copy of everythin from Cylc 7

2df63c7

wxtim force-pushed the feat.cylc-review branch from f35b60c to 02987a1 Compare December 4, 2025 11:30

wxtim marked this pull request as ready for review December 4, 2025 11:50

wxtim force-pushed the feat.cylc-review branch from 4d05257 to b781d3c Compare December 4, 2025 13:42

wxtim mentioned this pull request Dec 4, 2025

Allow users to specify pip installing cylc packages in editable mode … cylc/release-actions#136

Merged

1 task

wxtim requested review from ChrisPaulBennett and oliver-sanders December 4, 2025 15:54

wxtim force-pushed the feat.cylc-review branch 4 times, most recently from b528eea to 37dc894 Compare December 5, 2025 10:52

wxtim force-pushed the feat.cylc-review branch 6 times, most recently from f4fc283 to c4b0ae2 Compare December 8, 2025 11:27

This comment was marked as resolved.

Sign in to view

ChrisPaulBennett self-requested a review December 15, 2025 09:32

ChrisPaulBennett requested changes Dec 15, 2025

View reviewed changes

wxtim force-pushed the feat.cylc-review branch from 016d382 to a8c9dae Compare December 16, 2025 12:39

oliver-sanders added this to the 1.9.0 milestone Jan 20, 2026

oliver-sanders mentioned this pull request Jan 21, 2026

Cylc Review: support alternate home dirs. cylc/cylc-flow#6875

Open

8 tasks

oliver-sanders reviewed Feb 2, 2026

View reviewed changes

wxtim force-pushed the feat.cylc-review branch 3 times, most recently from 3f62d7d to cf0fa29 Compare February 3, 2026 10:28

wxtim requested a review from oliver-sanders February 3, 2026 14:04

wxtim force-pushed the feat.cylc-review branch 4 times, most recently from ced340c to 72e6e35 Compare February 4, 2026 13:41

wxtim added 2 commits February 4, 2026 14:00

Upgrade Cylc Review to Python 3

c99a715

wxtim force-pushed the feat.cylc-review branch from 0e3e6bc to dad9a37 Compare February 4, 2026 14:01

[skip ci]Turn off bodge that makes branch pass tests without cylc/cyl…

493ecad

…c-flow#7068 merged

This comment was marked as off-topic.

Sign in to view

Update .github/workflows/test.yml

e9d9e35

wxtim force-pushed the feat.cylc-review branch 5 times, most recently from 048ba70 to d582899 Compare February 17, 2026 13:48

Fix unicode decode errors.

9ba183f

wxtim force-pushed the feat.cylc-review branch from d582899 to 9ba183f Compare February 17, 2026 14:01

wxtim commented Feb 17, 2026

View reviewed changes

.github/workflows/test.yml Show resolved Hide resolved

Apply suggestion from @wxtim

910c94f



		def get_review_service_config(
		port: Annotated[int, Ge(0)] = 8042,

Conversation

wxtim commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChrisPaulBennett commented Dec 8, 2025

Uh oh!

wxtim commented Dec 8, 2025

Uh oh!

This comment was marked as resolved.

Uh oh!

ChrisPaulBennett left a comment

Choose a reason for hiding this comment

Uh oh!

oliver-sanders commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oliver-sanders left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oliver-sanders Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wxtim commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxtim commented Feb 4, 2026

Uh oh!

This comment was marked as off-topic.

wxtim commented Feb 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wxtim commented Nov 26, 2025 •

edited

Loading

oliver-sanders commented Feb 2, 2026 •

edited

Loading

wxtim commented Feb 3, 2026 •

edited

Loading