Allow users to specify pip installing cylc packages in editable mode …#136
Merged
Allow users to specify pip installing cylc packages in editable mode …#136
Conversation
6c413c1 to
13e5e3a
Compare
…to allow coverage checking
13e5e3a to
99e1858
Compare
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
8 tasks
MetRonnie
approved these changes
Jan 27, 2026
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Member
|
Has this broken the cylc-admin system tests? https://github.com/cylc/cylc-admin/actions/runs/21423161795
|
Member
|
Sadly, though they weren't exactly in perfect health before - cylc/cylc-admin#219 |
Member
|
cylc-doc nightly also broken - https://github.com/cylc/cylc-doc/actions/runs/21464139044/job/61822580690 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to allow coverage checking
Description
Whilst setting up coverage for Cylc Functional style tests for cylc review
I found that editable installs are required.
Annoyingly the issue for the deprecation warning for the old
egg=syntax contains the following:Warning
Editable VCS installs do NOT yet support the Direct URL syntax. This means the egg fragment is the only supported way to request an extra for a VCS URL. If this is your situation, you will need to wait until pip adds Direct URL support for editable VCS installs. We will NOT remove support for URLs with invalid egg fragments until there is a supported alternative for all use-cases.
Checklist
README.mdand have opened this against the correct branch & milestone