-
Notifications
You must be signed in to change notification settings - Fork 3.4k
breaking: remove support for webpack 4 and webpack-dev-server 4 inside @cypress/webpack-preprocessor
and @cypress/webpack-dev-server
#31506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cypress
|
Project |
cypress
|
Branch Review |
breaking/remove_webpack_4
|
Run status |
|
Run duration | 15m 53s |
Commit |
|
Committer | AtofStryker |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
1
|
|
29
|
|
0
|
|
794
|
View all changes introduced in this branch ↗︎ |
UI Coverage
63.64%
|
|
---|---|
|
30
|
|
56
|
Accessibility
96.18%
|
|
---|---|
|
0 critical
4 serious
1 moderate
0 minor
|
|
193
|
7f9ebf0
to
8e1a482
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will need to be @cypress/webpack-preprocessor@7
in Cypress 15
8e1a482
to
0de82b3
Compare
0de82b3
to
ec495dd
Compare
@cypress/webpack-preprocessor
and @cypress/webpack-dev-server
… webpack-batteries-included-preprocessor is webpack 5. both packages need a breaking version published (check the peerDeps in WBIP)" breaking: webpack/wds v4 is no longer supported in @cypress/webpack-dev-server update changelog and clean up comments
ec495dd
to
1e37404
Compare
going to merge this in with the semantic PR failure because we want a separate change item fro wbip and wds |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
@cypress/webpack-dev-server
#31605Additional details
With Cypress 15, we have made the decision to remove support for Webpack 4. With Webpack 4 being no longer actively maintained and Webpack 5 being out for almost 5 years, we have made the decision to remove support for Webpack 4 from
@cypress/webpack-preprocessor
and@cypress/webpack-dev-server
. Additionally, we are removing Webpack Dev Server 4 support from@cypress/webpack-dev-server
as it is in maintenance mode and only receiving security updates.This change may be disruptive to some users, hence why we have a full migration guide to help users transition.
Steps to test
The system tests have been modified to error if a user has webpack 4 or webpack-dev-server 4 installed, which seem valuable since the usage is still somewhat high and we want to make sure to handle the error gracefully.
The other option is to test the built binaries against a
webpack/webpack-dev-server 4
setup, which can be seen in this repo off of a few different branchesHow has the user experience changed?
Users will notice when scaffolding a webpack project in Cypress 15 that webpack 4 no longer fulfills the scafolded dependency list
If skipping this, or installing Cypress 15 with either Webpack 4 or Webpack Dev Server 4, the following errors with throw from the config instantiation
The only way to work around this is the method laid out in the migration guide, which I have tested in https://github.com/AtofStryker/cypress-webpack-4 on various branches
PR Tasks
cypress-documentation
? chore: add webpack 4 removal guide cypress-documentation#6164type definitions
?