Expose 'open' as prop for more component control #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...for allowing the modal-picker to become a "controlled" component.
bdelville
pushed a commit
to bdelville/react-native-modal-picker
that referenced
this pull request
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modal is awesome, and I love using it! That being said, I found myself wishing I had the ability to treat the modal-picker as a more "controlled" component, where its activation can be triggered programmatically, or through prop-flow further upstream, and not just through manual clicks somewhere in the same class.
This small change supports that. Let me know if you have any suggestions.