Skip to content

Expose 'open' as prop for more component control #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Expose 'open' as prop for more component control #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c1adeb
Update README.md
dggriffin Nov 4, 2016
8b1b7a1
Expose 'open' prop...
dggriffin Nov 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ class SampleApp extends Component {
## Props

* `data - []` required, array of objects with a unique key and label
* `open - boolean` optional, boolean that triggers whether or not the dialog is shown
* `style - object` optional, style definitions for the root element
* `onChange - function` optional, callback function, when the users has selected an option
* `initValue - string` optional, text that is initially shown on the button
Expand Down
3 changes: 3 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ let componentIndex = 0;

const propTypes = {
data: PropTypes.array,
open: PropTypes.bool,
onChange: PropTypes.func,
initValue: PropTypes.string,
style: View.propTypes.style,
Expand All @@ -38,6 +39,7 @@ const propTypes = {

const defaultProps = {
data: [],
open: false,
onChange: ()=> {},
initValue: 'Select me!',
style: {},
Expand Down Expand Up @@ -82,6 +84,7 @@ export default class ModalPicker extends BaseComponent {
if (nextProps.initValue != this.props.initValue) {
this.setState({selected: nextProps.initValue});
}
this.setState({modalVisible: nextProps.open});
}

onChange(item) {
Expand Down