Skip to content

Conversation

@te6-in
Copy link
Member

@te6-in te6-in commented Dec 18, 2025

Summary by CodeRabbit

  • 스타일
    • Checkmark 컴포넌트의 ghost 변형 중 neutral 톤에서 아이콘 색상이 더 선명한 중립 색상으로 변경되었습니다.
    • 동일 상태에서 아이콘 색상에 부드러운 색상 전환(지속시간 및 타이밍 적용)이 추가되어 색상 변화가 자연스럽게 표시됩니다.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025

🦋 Changeset detected

Latest commit: df2b8a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@seed-design/rootage-artifacts Patch
@seed-design/css Patch
@seed-design/figma Patch
@seed-design/mcp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • packages/css/all.css is excluded by !packages/css/**/*
  • packages/css/all.min.css is excluded by !packages/css/**/*

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Checkmark 컴포넌트의 아이콘 색상 토큰과 전환 속성(지속시간·타이밍 함수)이 추가되고, variant="ghost", tone="neutral"에서 아이콘 색상이 $color.fg.neutral-muted에서 $color.fg.neutral로 변경되었습니다. 변경사항은 패치(changeset)로 기록되었습니다.

Changes

Cohort / File(s) 변경 요약
Changeset 기록
.changeset/early-chairs-bet.md
패치 항목 추가: @seed-design/rootage-artifacts, @seed-design/css 업데이트 기록 및 변경 설명 문서화
컴포넌트 스펙
packages/rootage/components/checkmark.yaml
아이콘 스키마에 colorDuration, colorTimingFunction 토큰 추가; base/definitions에 토큰 바인딩 추가; variant=ghost, tone=neutral에서 아이콘 색상 토큰을 $color.fg.neutral-muted$color.fg.neutral로 변경하고 전환 관련 토큰 적용
스타일/레시피 구현
packages/qvism-preset/src/recipes/checkmark.ts
ghost 변형의 아이콘 스타일에 transition 속성 추가하여 아이콘 색상에 대해 지정된 duration·timing-function 적용 (루트 전환과 일관된 동작)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🐰 회색 점이 살며시 밝아졌네,
토큰을 껴안고 한 박자 쉬어,
색이 부드럽게 미소 지을 때,
작은 변화가 또 반짝—
당근 하나로 축하할게! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed PR 제목이 변경 사항의 주요 내용을 명확하게 요약하고 있습니다. Checkmark 컴포넌트의 ghost variant, neutral tone에서 아이콘 색상을 fg.neutral로 업데이트하고 색상 전환 효과를 추가한 내용을 정확히 반영합니다.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2025

Deploying seed-design-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6600de1
Status: ✅  Deploy successful!
Preview URL: https://dfd4ab92.seed-design.pages.dev
Branch Preview URL: https://feat-checkmark-variantghost.seed-design.pages.dev

View logs

@te6-in te6-in changed the title feat: update checkmark variant=ghost tone=neutral color to fg.neutral feat: update checkmark variant=ghost tone=neutral color to fg.neutral, add icon color transition Jan 5, 2026
…color

# Conflicts:
#	packages/css/all.min.css
@te6-in te6-in merged commit 9119723 into dev Jan 6, 2026
8 checks passed
@te6-in te6-in deleted the feat/checkmark-variantghost-toneneutral-icon-color branch January 6, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant