Skip to content

feat: update checkmark variant=ghost tone=neutral color to fg.neutral, add icon color transition #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
te6-in merged 6 commits into from
Jan 6, 2026
Merged

feat: update checkmark variant=ghost tone=neutral color to fg.neutral, add icon color transition #1111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
73693be
feat: update checkmark variant=ghost tone=neutral color to fg.neutral
te6-in Dec 17, 2025
49f4e41
docs: changeset
te6-in Dec 18, 2025
5183bf4
feat: add proper transition to icon on variant=ghost
te6-in Jan 5, 2026
6600de1
Merge branch 'dev' into feat/checkmark-variantghost-toneneutral-icon-…
te6-in Jan 5, 2026
746df78
docs
te6-in Jan 5, 2026
df2b8a1
Merge branch 'dev' into feat/checkmark-variantghost-toneneutral-icon-…
te6-in Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/early-chairs-bet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@seed-design/rootage-artifacts": patch
"@seed-design/css": patch
---

Checkmark `variant=ghost` `tone=neutral`에서 icon의 색상을 $color.fg.neutral로 변경하고 색상 트랜지션을 추가합니다.
16 changes: 15 additions & 1 deletion docs/public/rootage/components/checkmark.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@
},
"size": {
"type": "dimension"
},
"colorDuration": {
"type": "duration"
},
"colorTimingFunction": {
"type": "cubicBezier"
}
}
}
Expand Down Expand Up @@ -288,6 +294,14 @@
"color": {
"type": "color",
"value": "$color.fg.placeholder"
},
"colorDuration": {
"type": "duration",
"value": "$duration.color-transition"
},
"colorTimingFunction": {
"type": "cubicBezier",
"value": "$timing-function.easing"
}
}
}
Expand Down Expand Up @@ -385,7 +399,7 @@
"icon": {
"color": {
"type": "color",
"value": "$color.fg.neutral-muted"
"value": "$color.fg.neutral"
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion packages/css/all.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3015,6 +3015,7 @@

.seed-checkmark__icon--variant_ghost {
color: var(--seed-color-fg-placeholder);
transition: color var(--seed-duration-color-transition) var(--seed-timing-function-easing);
display: block;
}

Expand Down Expand Up @@ -3063,7 +3064,7 @@
}

.seed-checkmark__icon--variant_ghost-tone_neutral:not(:is(:disabled, [disabled], [data-disabled])):is(:checked, :indeterminate, [data-checked], [data-indeterminate]) {
color: var(--seed-color-fg-neutral-muted);
color: var(--seed-color-fg-neutral);
}

.seed-checkmark__root--variant_ghost-tone_brand:not(:is(:disabled, [disabled], [data-disabled])):is(:checked, :indeterminate, [data-checked], [data-indeterminate]):is(:active, [data-active]) {
Expand Down
2 changes: 1 addition & 1 deletion packages/css/all.min.css
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion packages/css/recipes/checkmark.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
.seed-checkmark__icon--variant_ghost {
display: block;
color: var(--seed-color-fg-placeholder);
transition: color var(--seed-duration-color-transition) var(--seed-timing-function-easing);
}
.seed-checkmark__icon--variant_ghost:is(:disabled, [disabled], [data-disabled]) {
color: var(--seed-color-fg-disabled);
Expand Down Expand Up @@ -83,7 +84,7 @@
background: var(--seed-color-palette-gray-200);
}
.seed-checkmark__icon--variant_ghost-tone_neutral:not(:is(:disabled, [disabled], [data-disabled])):is(:checked, :indeterminate, [data-checked], [data-indeterminate]) {
color: var(--seed-color-fg-neutral-muted);
color: var(--seed-color-fg-neutral);
}
.seed-checkmark__root--variant_ghost-tone_brand:not(:is(:disabled, [disabled], [data-disabled])):is(:checked, :indeterminate, [data-checked], [data-indeterminate]):is(:active, [data-active]) {
background: var(--seed-color-palette-carrot-200);
Expand Down
6 changes: 4 additions & 2 deletions packages/css/vars/component/checkmark.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ export declare const vars: {
"variantGhost": {
"enabled": {
"icon": {
"color": "var(--seed-color-fg-placeholder)"
"color": "var(--seed-color-fg-placeholder)",
"colorDuration": "var(--seed-duration-color-transition)",
"colorTimingFunction": "var(--seed-timing-function-easing)"
}
},
"pressed": {
Expand Down Expand Up @@ -107,7 +109,7 @@ export declare const vars: {
"variantGhostToneNeutral": {
"enabledSelected": {
"icon": {
"color": "var(--seed-color-fg-neutral-muted)"
"color": "var(--seed-color-fg-neutral)"
}
},
"pressedSelected": {
Expand Down
6 changes: 4 additions & 2 deletions packages/css/vars/component/checkmark.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ export const vars = {
"variantGhost": {
"enabled": {
"icon": {
"color": "var(--seed-color-fg-placeholder)"
"color": "var(--seed-color-fg-placeholder)",
"colorDuration": "var(--seed-duration-color-transition)",
"colorTimingFunction": "var(--seed-timing-function-easing)"
}
},
"pressed": {
Expand Down Expand Up @@ -107,7 +109,7 @@ export const vars = {
"variantGhostToneNeutral": {
"enabledSelected": {
"icon": {
"color": "var(--seed-color-fg-neutral-muted)"
"color": "var(--seed-color-fg-neutral)"
}
},
"pressedSelected": {
Expand Down
2 changes: 2 additions & 0 deletions packages/qvism-preset/src/recipes/checkmark.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ const checkmark = defineSlotRecipe({
display: "block",
color: vars.variantGhost.enabled.icon.color,

transition: `color ${vars.variantGhost.enabled.icon.colorDuration} ${vars.variantGhost.enabled.icon.colorTimingFunction}`,

[pseudo(disabled)]: {
color: vars.variantGhost.disabled.icon.color,
},
Expand Down
6 changes: 4 additions & 2 deletions packages/qvism-preset/src/vars/component/checkmark.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ export declare const vars: {
"variantGhost": {
"enabled": {
"icon": {
"color": "var(--seed-color-fg-placeholder)"
"color": "var(--seed-color-fg-placeholder)",
"colorDuration": "var(--seed-duration-color-transition)",
"colorTimingFunction": "var(--seed-timing-function-easing)"
}
},
"pressed": {
Expand Down Expand Up @@ -107,7 +109,7 @@ export declare const vars: {
"variantGhostToneNeutral": {
"enabledSelected": {
"icon": {
"color": "var(--seed-color-fg-neutral-muted)"
"color": "var(--seed-color-fg-neutral)"
}
},
"pressedSelected": {
Expand Down
6 changes: 4 additions & 2 deletions packages/qvism-preset/src/vars/component/checkmark.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ export const vars = {
"variantGhost": {
"enabled": {
"icon": {
"color": "var(--seed-color-fg-placeholder)"
"color": "var(--seed-color-fg-placeholder)",
"colorDuration": "var(--seed-duration-color-transition)",
"colorTimingFunction": "var(--seed-timing-function-easing)"
}
},
"pressed": {
Expand Down Expand Up @@ -107,7 +109,7 @@ export const vars = {
"variantGhostToneNeutral": {
"enabledSelected": {
"icon": {
"color": "var(--seed-color-fg-neutral-muted)"
"color": "var(--seed-color-fg-neutral)"
}
},
"pressedSelected": {
Expand Down
9 changes: 8 additions & 1 deletion packages/rootage/components/checkmark.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ data:
type: color
size:
type: dimension
colorDuration:
type: duration
colorTimingFunction:
type: cubicBezier
definitions:
base:
enabled:
Expand Down Expand Up @@ -80,6 +84,9 @@ data:
enabled:
icon:
color: $color.fg.placeholder
colorDuration: $duration.color-transition
colorTimingFunction: $timing-function.easing

pressed:
root:
color: $color.bg.transparent-pressed
Expand All @@ -100,7 +107,7 @@ data:
variant=ghost,tone=neutral:
enabled,selected:
icon:
color: $color.fg.neutral-muted
color: $color.fg.neutral
pressed,selected:
root:
color: $color.palette.gray-200
Expand Down