Skip to content

Comments

fix(rootage): add missing strokeWidth and rename stroke to strokeColor in chip-tab#1256

Merged
te6-in merged 1 commit intodevfrom
fix/rootage-chip-tab-missing-strokewidth
Feb 19, 2026
Merged

fix(rootage): add missing strokeWidth and rename stroke to strokeColor in chip-tab#1256
te6-in merged 1 commit intodevfrom
fix/rootage-chip-tab-missing-strokewidth

Conversation

@te6-in
Copy link
Member

@te6-in te6-in commented Feb 19, 2026

Summary

  • chip-tab rootage 스키마에서 stroke 속성을 strokeColor로 rename하고, 누락된 strokeWidth 속성을 추가합니다.
  • rootage YAML, 생성된 vars/타입 파일, recipe에 변경사항이 반영됩니다.

Test plan

  • bun generate:all 실행하여 생성물이 일치하는지 확인
  • bun test:all 실행하여 기존 테스트 통과 확인

🤖 Generated with Claude Code

Summary by CodeRabbit

  • 스타일
    • 칩 탭 컴포넌트의 테두리 스타일이 개선되었습니다. 테두리 색상과 너비 속성이 더욱 명확하게 정의되어 디자인 토큰의 일관성이 향상되었습니다.

…r in chip-tab

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2026

⚠️ No Changeset found

Latest commit: b8487cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

📝 Walkthrough

개요

칩 탭 컴포넌트의 테두리 스타일링을 개선하기 위해 stroke 속성을 strokeColor로 변경하고, 새로운 strokeWidth 속성을 추가하여 색상과 너비를 분리했습니다.

변경 사항

Cohort / File(s) 요약
칩 탭 스타일링 리팩토링
packages/qvism-preset/src/recipes/chip-tabs.ts, packages/rootage/components/chip-tab.yaml
테두리 색상 속성을 stroke에서 strokeColor로 변경, strokeWidth 속성 추가(1px), 향후 strokeWidth를 토큰으로 대체할 계획에 대한 TODO 주석 추가

코드 리뷰 예상 소요 시간

🎯 2 (Simple) | ⏱️ ~10 minutes

🐰 경계선의 색과 너비를 나누어,
더욱 명확하고 세련된 디자인을 품다.
속성의 이름을 다듬으며,
칩 탭이 한층 우아해지네요! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목이 주요 변경 사항을 명확하게 요약합니다. chip-tab에서 stroke를 strokeColor로 이름을 바꾸고 strokeWidth를 추가한 것이 제목에 정확히 반영되어 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/rootage-chip-tab-missing-strokewidth

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Alpha Preview (Storybook)

@github-actions
Copy link
Contributor

Alpha Preview (Stackflow SPA)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/qvism-preset/src/recipes/chip-tabs.ts (1)

131-132: 생성된 vars에서 strokeWidth 토큰을 사용하도록 수정하세요.

triggerVars.variantNeutralOutline.enabled.root.strokeWidth가 생성된 타입에서 정확히 노출되어 있습니다. 하드코딩된 1px을 토큰으로 대체하면 디자인 시스템 변경 시 자동으로 반영됩니다.

♻️ strokeWidth 토큰 사용으로 변경
-          // TODO: replace 1px with triggerVars.variantNeutralOutline.enabled.root.strokeWidth
-          border: `1px solid ${triggerVars.variantNeutralOutline.enabled.root.strokeColor}`,
+          border: `${triggerVars.variantNeutralOutline.enabled.root.strokeWidth} solid ${triggerVars.variantNeutralOutline.enabled.root.strokeColor}`,
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/qvism-preset/src/recipes/chip-tabs.ts` around lines 131 - 132,
Replace the hardcoded border declaration that uses "1px" with the strokeWidth
token from triggerVars; specifically update the line that sets border (currently
`border: \`1px solid
${triggerVars.variantNeutralOutline.enabled.root.strokeColor}\``) to use
`${triggerVars.variantNeutralOutline.enabled.root.strokeWidth}` instead of "1px"
(and if the token is numeric ensure you append the correct unit, e.g.
`${triggerVars.variantNeutralOutline.enabled.root.strokeWidth}px`, otherwise use
the token value directly).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/qvism-preset/src/recipes/chip-tabs.ts`:
- Around line 131-132: Replace the hardcoded border declaration that uses "1px"
with the strokeWidth token from triggerVars; specifically update the line that
sets border (currently `border: \`1px solid
${triggerVars.variantNeutralOutline.enabled.root.strokeColor}\``) to use
`${triggerVars.variantNeutralOutline.enabled.root.strokeWidth}` instead of "1px"
(and if the token is numeric ensure you append the correct unit, e.g.
`${triggerVars.variantNeutralOutline.enabled.root.strokeWidth}px`, otherwise use
the token value directly).

@github-actions
Copy link
Contributor

Alpha Preview (Docs)

@te6-in te6-in merged commit 283675b into dev Feb 19, 2026
11 of 12 checks passed
@te6-in te6-in deleted the fix/rootage-chip-tab-missing-strokewidth branch February 19, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant