Conversation
…r in chip-tab Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
📝 Walkthrough개요칩 탭 컴포넌트의 테두리 스타일링을 개선하기 위해 변경 사항
코드 리뷰 예상 소요 시간🎯 2 (Simple) | ⏱️ ~10 minutes 시
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Alpha Preview (Storybook)
|
Alpha Preview (Stackflow SPA)
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/qvism-preset/src/recipes/chip-tabs.ts (1)
131-132: 생성된 vars에서 strokeWidth 토큰을 사용하도록 수정하세요.
triggerVars.variantNeutralOutline.enabled.root.strokeWidth가 생성된 타입에서 정확히 노출되어 있습니다. 하드코딩된1px을 토큰으로 대체하면 디자인 시스템 변경 시 자동으로 반영됩니다.♻️ strokeWidth 토큰 사용으로 변경
- // TODO: replace 1px with triggerVars.variantNeutralOutline.enabled.root.strokeWidth - border: `1px solid ${triggerVars.variantNeutralOutline.enabled.root.strokeColor}`, + border: `${triggerVars.variantNeutralOutline.enabled.root.strokeWidth} solid ${triggerVars.variantNeutralOutline.enabled.root.strokeColor}`,🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/qvism-preset/src/recipes/chip-tabs.ts` around lines 131 - 132, Replace the hardcoded border declaration that uses "1px" with the strokeWidth token from triggerVars; specifically update the line that sets border (currently `border: \`1px solid ${triggerVars.variantNeutralOutline.enabled.root.strokeColor}\``) to use `${triggerVars.variantNeutralOutline.enabled.root.strokeWidth}` instead of "1px" (and if the token is numeric ensure you append the correct unit, e.g. `${triggerVars.variantNeutralOutline.enabled.root.strokeWidth}px`, otherwise use the token value directly).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/qvism-preset/src/recipes/chip-tabs.ts`:
- Around line 131-132: Replace the hardcoded border declaration that uses "1px"
with the strokeWidth token from triggerVars; specifically update the line that
sets border (currently `border: \`1px solid
${triggerVars.variantNeutralOutline.enabled.root.strokeColor}\``) to use
`${triggerVars.variantNeutralOutline.enabled.root.strokeWidth}` instead of "1px"
(and if the token is numeric ensure you append the correct unit, e.g.
`${triggerVars.variantNeutralOutline.enabled.root.strokeWidth}px`, otherwise use
the token value directly).
Alpha Preview (Docs)
|
Summary
chip-tabrootage 스키마에서stroke속성을strokeColor로 rename하고, 누락된strokeWidth속성을 추가합니다.Test plan
bun generate:all실행하여 생성물이 일치하는지 확인bun test:all실행하여 기존 테스트 통과 확인🤖 Generated with Claude Code
Summary by CodeRabbit