Conversation
aluzzardi
requested review from
cwlbraa and
grouville
and removed request for
cwlbraa
tiborvass
reviewed
Jun 27, 2025
| cmd := exec.CommandContext(ctx, "git") | ||
| cmd.Dir = r.userRepoPath | ||
| cmd.Args = diffArgs | ||
| cmd.Stdout = w |
Contributor
There was a problem hiding this comment.
Not specific to this PR, but in general i think we should not ignore stderr and either do os.Stderr and/or log it to the log file.
Contributor
Author
There was a problem hiding this comment.
Workaround implemented -- PTAL
tiborvass
reviewed
Jun 27, 2025
tiborvass
reviewed
Jun 27, 2025
tiborvass
reviewed
Jun 27, 2025
Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>
Co-authored-by: Tibor Vass <tiborvass@users.noreply.github.com> Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
Co-authored-by: Tibor Vass <tiborvass@users.noreply.github.com> Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
Co-authored-by: Tibor Vass <tiborvass@users.noreply.github.com> Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>
tiborvass
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cu diffcu logcode into Repositorycu log -pand don't show patches by defaultcu log