-
Notifications
You must be signed in to change notification settings - Fork 171
cu diff #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cu diff #135
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
46e1a98
cu diff
aluzzardi a4415f0
cu log/diff: add tests
aluzzardi 3780e1c
Update environment/integration/repository_test.go
d1a568e
Update environment/integration/repository_test.go
ae907f8
Update environment/integration/repository_test.go
fa582aa
cu log/diff: include stderr
aluzzardi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "os" | ||
|
|
||
| "github.com/dagger/container-use/repository" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| var diffCmd = &cobra.Command{ | ||
| Use: "diff <env>", | ||
| Short: "Show changes between the environment and the local branch", | ||
| Args: cobra.ExactArgs(1), | ||
| ValidArgsFunction: suggestEnvironments, | ||
| RunE: func(app *cobra.Command, args []string) error { | ||
| ctx := app.Context() | ||
|
|
||
| // Ensure we're in a git repository | ||
| repo, err := repository.Open(ctx, ".") | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return repo.Diff(ctx, args[0], os.Stdout) | ||
| }, | ||
| } | ||
|
|
||
| func init() { | ||
| rootCmd.AddCommand(diffCmd) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not specific to this PR, but in general i think we should not ignore stderr and either do os.Stderr and/or log it to the log file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workaround implemented -- PTAL