Merged
Conversation
- Add debug output to troubleshoot command execution - Handle different output formats from dagster-cloud CLI when --wait is used - Extract run ID from status messages like 'Run <id> is in progress' - Fix GITHUB_OUTPUT format issue
- Test run script without wait flag (default behavior) - Test run script with wait flag enabled (multi-line output) - Test various truthy values for wait parameter - Test backwards compatibility when INPUT_WAIT is not set - Maintain original test for backwards compatibility - Handle extraction of run ID from both single line and multi-line outputs
- Make run ID regex more flexible to handle both UUIDs and test strings - Change from strict 36-char UUID pattern to more permissive alphanumeric pattern - Allows tests to pass with mock data like 'some-run' while still working with real UUIDs
Closed
|
Your pull request is automatically being deployed to Dagster Cloud.
|
gibsondan
approved these changes
Aug 25, 2025
Comment on lines
+34
to
+36
| interval: | ||
| required: false | ||
| description: "Interval in seconds between status checks when waiting for job completion. Can only be used when wait is true." |
Member
There was a problem hiding this comment.
i think this defaults to 30 if nothing is set, maybe worth mentioning here
cnolanminich
commented
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supercedes #234 -- I tried adding streaming output but every permutation I tried resulted in non-blocking behavior, which invalidated the point of the PR. This PR is the same as the one reviewed previously but with the --interval param. Tested this by released to
add-wait-paramand testing https://github.com/dagster-io/hooli-data-eng-pipelines/actions/runs/16996834025/job/48342049932 with both wait and wait removed