Classify candidate rejection feedback with Bragi #3563

davidercruz · 2026-02-11T13:08:05Z

This adds Bragi rejection classification to the opportunity feedback worker while keeping existing per-item feedback parsing. It stores structured rejection reasons and summary on OpportunityMatch via a new JSONB column and migration. The Bragi schema dependency is bumped to 0.2.70 to use the typed classifyRejectionFeedback RPC. Tests now cover storing rejection classification, idempotent skip when already present, and graceful handling of ConnectError.

pulumi · 2026-02-11T13:09:19Z

🍹 The Update (preview) for dailydotdev/api/prod (at 126d987) was successful.

Resource Changes

    Name                                                       Type                           Operation
~   vpc-native-private-deployment                              kubernetes:apps/v1:Deployment  update
~   vpc-native-expire-super-agent-trial-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-public-threshold-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-update-trending-cron                            kubernetes:batch/v1:CronJob    update
-   vpc-native-api-db-migration-e1dc464f                       kubernetes:batch/v1:Job        delete
~   vpc-native-clean-zombie-users-cron                         kubernetes:batch/v1:CronJob    update
~   vpc-native-daily-digest-cron                               kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-sync-subscription-with-cio-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-deployment                                      kubernetes:apps/v1:Deployment  update
~   vpc-native-clean-zombie-opportunities-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-clickhouse-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-ws-deployment                                   kubernetes:apps/v1:Deployment  update
~   vpc-native-temporal-deployment                             kubernetes:apps/v1:Deployment  update
~   vpc-native-personalized-digest-deployment                  kubernetes:apps/v1:Deployment  update
~   vpc-native-validate-active-users-cron                      kubernetes:batch/v1:CronJob    update
-   vpc-native-api-clickhouse-migration-e1dc464f               kubernetes:batch/v1:Job        delete
~   vpc-native-update-views-cron                               kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-analytics-history-clickhouse-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-bg-deployment                                   kubernetes:apps/v1:Deployment  update
~   vpc-native-user-profile-updated-sync-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-user-companies-cron                kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-tag-view-cron                     kubernetes:batch/v1:CronJob    update
+   vpc-native-api-clickhouse-migration-e57b8b25               kubernetes:batch/v1:Job        create
~   vpc-native-user-profile-analytics-clickhouse-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-generate-search-invites-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-check-analytics-report-cron                     kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-images-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-hourly-notification-cron                        kubernetes:batch/v1:CronJob    update
+   vpc-native-api-db-migration-e57b8b25                       kubernetes:batch/v1:Job        create
~   vpc-native-update-tags-str-cron                            kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-stale-user-transactions-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-calculate-top-readers-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-update-highlighted-views-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-history-day-clickhouse-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-generic-referral-reminder-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-recommendations-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-user-posts-analytics-refresh-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-gifted-plus-cron                          kubernetes:batch/v1:CronJob    update
... and 1 other changes

src/entity/OpportunityMatch.ts

rebelchris · 2026-02-11T13:17:28Z

src/migration/1770812936388-AddRejectionClassificationToOpportunityMatch.ts

+  public async up(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(
+      `ALTER TABLE "opportunity_match"
+       ADD "rejectionClassification" jsonb DEFAULT null`,


Should also modify here then

rebelchris · 2026-02-11T13:18:39Z

src/workers/opportunity/parseOpportunityFeedback.ts

+  value?: unknown;
+};
+
+const mapPreferenceFields = (


Why do we need this?

rebelchris · 2026-02-11T13:19:24Z

src/workers/opportunity/parseOpportunityFeedback.ts

+          ? `${opportunity.title}\n${opportunity.tldr}`
+          : undefined;
+
+        const result = await bragiClient.garmr.execute(() =>


This flow is a bit weird, you should probably do this where we request the feedback? This only happens once we get feedback so it won't even trigger for rejection I don't think.

capJavert · 2026-02-11T14:12:06Z

src/workers/opportunity/parseOpportunityFeedback.ts

+        if (err instanceof ConnectError) {
+          logger.error(
+            { err, opportunityId, userId, answer: item.answer },
+            'ConnectError when parsing feedback',
+          );
+          return item;
+        }
+        throw err;


Since you are using Promise.all, throw on any of them will cancel result for all of them, so I think its better to not throw and ignore errors from bragi, there are retries already.

capJavert · 2026-02-11T14:13:04Z

src/migration/1770812936388-AddRejectionClassificationToOpportunityMatch.ts

+  public async up(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(
+      `ALTER TABLE "opportunity_match"
+       ADD "rejectionClassification" jsonb`,


add column if not exists, also for drop

capJavert · 2026-02-11T14:13:57Z

src/workers/opportunity/parseOpportunityFeedback.ts

+  });
+
+  if (!match) {
+    logger.warn({ opportunityId, userId }, 'No match found for feedback');


you can make all of this warns debug (here and below), no point in spamming logs, agent should know this already 😫

capJavert · 2026-02-11T14:14:52Z

src/workers/opportunity/parseOpportunityFeedback.ts

+  // Skip rejection classification if already set (idempotent)
+  if (match.rejectionClassification) {
+    return;
+  }


With #3540 there can be multiple feedbacks, so potentially we need to overwrite it and then save current result in history column

Co-authored-by: Ole-Martin Bratteng <[email protected]>

- Don't throw errors in Promise.all to avoid cancelling sibling results - Change warn/error logs to debug to reduce log noise - Allow overwriting rejectionClassification for rematch support - Remove ConnectError-specific handling in favor of catching all errors Co-Authored-By: Claude Opus 4.6 <[email protected]>

Co-Authored-By: Claude Opus 4.6 <[email protected]>

davidercruz requested review from a team and capJavert as code owners February 11, 2026 13:08

davidercruz requested review from AmarTrebinjac, omBratteng and rebelchris February 11, 2026 13:08

omBratteng reviewed Feb 11, 2026

View reviewed changes

src/entity/OpportunityMatch.ts Outdated Show resolved Hide resolved

davidercruz force-pushed the davidercruz/candidate-feedback-bragi branch from ce4fe86 to b0e932a Compare February 11, 2026 13:17

rebelchris requested changes Feb 11, 2026

View reviewed changes

capJavert reviewed Feb 11, 2026

View reviewed changes

davidercruz force-pushed the davidercruz/candidate-feedback-bragi branch from bdb75a7 to 384f737 Compare February 12, 2026 11:33

davidercruz requested a review from rebelchris February 12, 2026 16:09

davidercruz and others added 9 commits February 12, 2026 16:11

Add rejection feedback classification via Bragi

218601f

fix: set correct default

f66b0bf

Co-authored-by: Ole-Martin Bratteng <[email protected]>

Address review feedback for opportunity rejection parsing

ee3c304

Add IF NOT EXISTS / IF EXISTS guards to migration

cf8b6fb

Co-Authored-By: Claude Opus 4.6 <[email protected]>

Fix CI failures for rejection classification and CDC payload tests

e0e729a

Consolidate rejected opportunity feedback into existing worker

0cdc2ec

Co-Authored-By: Claude Opus 4.6 <[email protected]>

Align rejection classification default and guard semantics

db75685

Reclassify rejection feedback on subsequent submissions

126d987

davidercruz force-pushed the davidercruz/candidate-feedback-bragi branch from e07d9f9 to 126d987 Compare February 12, 2026 16:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Classify candidate rejection feedback with Bragi #3563

Classify candidate rejection feedback with Bragi #3563

Uh oh!

davidercruz commented Feb 11, 2026

Uh oh!

pulumi bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

rebelchris Feb 11, 2026

Uh oh!

rebelchris Feb 11, 2026

Uh oh!

rebelchris Feb 11, 2026

Uh oh!

capJavert Feb 11, 2026

Uh oh!

capJavert Feb 11, 2026 •

edited

Loading

Uh oh!

capJavert Feb 11, 2026 •

edited

Loading

Uh oh!

capJavert Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Classify candidate rejection feedback with Bragi #3563

Are you sure you want to change the base?

Classify candidate rejection feedback with Bragi #3563

Uh oh!

Conversation

davidercruz commented Feb 11, 2026

Uh oh!

pulumi bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resource Changes

Uh oh!

Uh oh!

rebelchris Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

rebelchris Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

rebelchris Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

capJavert Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

capJavert Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

capJavert Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

capJavert Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pulumi bot commented Feb 11, 2026 •

edited

Loading

capJavert Feb 11, 2026 •

edited

Loading

capJavert Feb 11, 2026 •

edited

Loading