Mediastyle Notifications #914
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've used Google Play Music's Oreo notifications as a sort of template, at least in O+. Here's what I've done: * Prev, pause/play, next icons in compact mode, rate good/bad in expanded. Prev/next change to rw/ff as inside the app. * Persistent notification setting now keeps the notification persistent (Nougat+). It will stay indefinitely, rather than being cancelled when the service gets killed. * Only prev, play/pause, next buttons in expanded view for < N. You get a much larger album icon this way. * New notification icon based on the launcher icon. * Further refined the dealing with startForeground related crashes. Tested on APIs 19, 23, 24, 26 in emulator and on my pixel (28). Been running for a week without issue on pixel.
Contributor
|
That looks great. The only thing that feels weird to me is the order of thumbs up/thumbs down. I don't think I've got any other apps that implement that right now though so nothing to compare it to. |
Contributor
Author
|
GPM does, they're in the same order. It also looks like there's a tiny bit more padding around play/pause. |
Contributor
…rewind_fastforward Fixed rewind and fast forward behavior
mlim15
added a commit
to mlim15/Audinaut
that referenced
this pull request
Jan 11, 2020
mlim15
added a commit
to mlim15/Audinaut
that referenced
this pull request
Jan 11, 2020
popeen
added a commit
to popeen/Booksonic-App
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've used Google Play Music's Oreo notifications as a sort of template, at least in O+. Here's what I've done:
Tested on APIs 19, 23, 24, 26 in emulator and on my pixel (28). Been running for a week without issue on pixel.
Some of the choices (such as which buttons to display < 24) are subjective, please let me know if you have different ideas!