fixed #14002 - added missing Boost include for testrunner
#7660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
changed the title
testrunner
|
See https://github.com/danmar/cppcheck/actions/runs/16191580303 for failed builds with the newly added job and no fix applied. |
|
#7658 will fix the issue with boost. |
pfultz2
reviewed
Jul 11, 2025
| target_externals_include_directories(testrunner PRIVATE ${PROJECT_SOURCE_DIR}/externals/simplecpp/) | ||
| if (Boost_FOUND) | ||
| target_include_directories(testrunner SYSTEM PRIVATE ${Boost_INCLUDE_DIRS}) | ||
| endif() |
There was a problem hiding this comment.
Having to updated all the consumers when dependencies change is very fragile and error-prone. #7658 fixes that issue.
There was a problem hiding this comment.
Yes, but that should not be merged so close to the release. And fixing such a minor issue within implicitly in a major rework is not great.
There was a problem hiding this comment.
Its always a small fix while technical debt piles up. Its best to take the opportunity to fix the issue once and for all.
pfultz2
approved these changes
Jul 18, 2025
|
@danmar @orbitcowboy @chrchr-github Can you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes build with Boost installed in non-default system include dir