-
Couldn't load subscription status.
- Fork 1.5k
fixed #14002 - added missing Boost include for testrunner
#7660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -243,6 +243,39 @@ jobs: | |
| run: | | ||
| ls lib/*.cpp | xargs -n 1 -P $(nproc) g++ -fsyntax-only -std=c++0x -Ilib -Iexternals -Iexternals/picojson -Iexternals/simplecpp -Iexternals/tinyxml2 -DNONNEG | ||
|
|
||
| build_cmake_boost: | ||
|
|
||
| strategy: | ||
| matrix: | ||
| os: [macos-13, macos-15] # non-macos platforms are already built with Boost in other contexts | ||
| fail-fast: false # Prefer quick result | ||
|
|
||
| runs-on: ${{ matrix.os }} | ||
|
|
||
| env: | ||
| # TODO: figure out why there are cache misses with PCH enabled | ||
| CCACHE_SLOPPINESS: pch_defines,time_macros | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: ccache | ||
| uses: hendrikmuhs/[email protected] | ||
| with: | ||
| key: ${{ github.workflow }}-${{ github.job }}-${{ matrix.os }} | ||
|
|
||
| # coreutils contains "nproc" | ||
| - name: Install missing software on macos | ||
| run: | | ||
| brew install coreutils boost | ||
|
|
||
| - name: CMake build on macOS (with Boost) | ||
| run: | | ||
| cmake -S . -B cmake.output.boost -G "Unix Makefiles" -DBUILD_TESTS=On -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache | ||
| cmake --build cmake.output.boost -- -j$(nproc) | ||
|
|
||
| build: | ||
|
|
||
| strategy: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having to updated all the consumers when dependencies change is very fragile and error-prone. #7658 fixes that issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but that should not be merged so close to the release. And fixing such a minor issue within implicitly in a major rework is not great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its always a small fix while technical debt piles up. Its best to take the opportunity to fix the issue once and for all.