DAOS-16501 build: Support of mercury with ASan #16917

knard38 · 2025-09-27T00:33:28Z

Description

Instrument mercury with libasan according to build option SANITIZERS

Steps for the author:

Commit message follows the guidelines.
Appropriate Features or Test-tag pragmas were used.
Appropriate Functional Test Stages were run.
At least two positive code reviews including at least one code owner from each category referenced in the PR.
Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

Gatekeeper requested (daos-gatekeeper added as a reviewer).

github-actions · 2025-09-27T00:33:47Z

Ticket title is 'LRZ: m02r01s10dao coredump - invalid free'
Status is 'Resolved'
Labels: 'lrz'
https://daosio.atlassian.net/browse/DAOS-16501

daosbuild3 · 2025-09-30T11:25:30Z

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16917/1/execution/node/1462/log

Instrument mercury with libasan according to build option SANITIZERS Signed-off-by: Cedric Koch-Hofer <[email protected]>

daosbuild3 · 2025-10-08T06:54:49Z

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16917/2/testReport/

…/daos-16501-part1

daosbuild3 · 2025-10-09T14:15:10Z

Test stage NLT on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16917/3/display/redirect

daosbuild3 · 2025-10-09T15:12:01Z

Test stage Unit Test bdev with memcheck on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16917/3/display/redirect

daosbuild3 · 2025-10-09T15:13:21Z

Test stage Unit Test on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16917/3/display/redirect

daosbuild3 · 2025-10-09T15:14:24Z

Test stage Unit Test bdev on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16917/3/display/redirect

daosbuild3 · 2025-10-09T15:14:31Z

Test stage Unit Test with memcheck on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16917/3/display/redirect

…/daos-16501-part1

jolivier23

You need to add an entry to daos.spec changelog, bump the daos and mercury versions. See this:

Without updating the mercury version, this will never build in CI because there is already a mercury to use.

https://github.com/daos-stack/daos/blob/master/docs/dev/development.md#updating-a-3rd-party-component

soumagne

ok based on Jeff's comment, I'll ask you to hold on this PR for now until I update mercury myself with this patch included. (There is also not much that you gain currently from building mercury with asan options, except slightly better traces)

soumagne · 2025-10-24T21:52:40Z

@knard38 see new option I have added in mercury-hpc/mercury@74dda4a

knard38 · 2025-10-27T10:16:29Z

@knard38 see new option I have added in mercury-hpc/mercury@74dda4a

I am going to update the PR accordingly

…/daos-16501-part1

Integrate reviewers comments: - Fix CI integration - Use of official mercury patch 74dda4a Miscellaneous fixes related to package build. Signed-off-by: Cedric Koch-Hofer <[email protected]>

knard38 · 2025-10-27T14:14:42Z

You need to add an entry to daos.spec changelog, bump the daos and mercury versions. See this:

Without updating the mercury version, this will never build in CI because there is already a mercury to use.

https://github.com/daos-stack/daos/blob/master/docs/dev/development.md#updating-a-3rd-party-component

Fix CI integration

knard38 · 2025-10-27T14:14:59Z

@knard38 see new option I have added in mercury-hpc/mercury@74dda4a

Use official mercury patch 74dda4a

knard38 · 2025-10-27T14:18:37Z

You need to add an entry to daos.spec changelog, bump the daos and mercury versions. See this:
Without updating the mercury version, this will never build in CI because there is already a mercury to use.
https://github.com/daos-stack/daos/blob/master/docs/dev/development.md#updating-a-3rd-party-component

Fix CI integration

Fixed with commit 5cb9bbe

knard38 · 2025-10-27T14:18:44Z

@knard38 see new option I have added in mercury-hpc/mercury@74dda4a

Use official mercury patch 74dda4a

Fixed with commit 5cb9bbe

soumagne · 2025-10-27T22:40:49Z

utils/rpms/daos.spec

 Version:       2.7.101
-Release:       16%{?relval}%{?dist}
+Release:       17%{?relval}%{?dist}
 Summary:       DAOS Storage Engine


@jolivier23 it does not make sense to me, why would someone need to update the daos.spec file in this case? we're not changing the min required version of mercury etc.

Because the daos changelog is now the only documentation we have that something changed. I'm open to other options though. Or maybe the gitlog on utils/rpms/package_info.sh is enough?

Remove daos.spec update

Remove daos.spec update

Fixed with commit 8eb204a

@jolivier23 is there not a way to include a changelog with fpm ? imo we want the changelog to be in the mercury rpm itself, not the DAOS one.

I see in the doc they have
--rpm-changelog FILEPATH

Add changelog from FILEPATH contents

ignore my last comment, looks like I can't read past 2 comments :D I see your comment now in #17063

For the Mercury change log update, I will wait for #17063 to be merged.
Is that OK for you @soumagne and @jolivier23 ?

For the Mercury change log update, I will wait for #17063 to be merged. Is that OK for you @soumagne and @jolivier23 ?

Restore Mercury changelog

For the Mercury change log update, I will wait for #17063 to be merged. Is that OK for you @soumagne and @jolivier23 ?

Restore Mercury changelog

Fixed with commit 89f602f and 967bc9f

…/daos-16501-part1

jolivier23 · 2025-10-29T20:11:58Z

debian/changelog

+  [ Jeff Olivier]
+  * Make daos-spdk conflict with spdk
+
+ -- Jeff Olivier <[email protected]>  Mon, 19 May 2025 14:12:00 -0700


The whole debian folder is no longer used since we produce .deb files using fpm. We shoudl just remove the folder rather than updating this file

Remove Debian packaging update

Remove Debian packaging update

Fixed with commit 8eb204a

jolivier23 · 2025-10-29T20:17:25Z

I pushed this: #17050

Integrate reviewers comments: - Remove daos.spec update - Remove Debian packaging update Signed-off-by: Cedric Koch-Hofer <[email protected]>

jolivier23 · 2025-10-31T15:52:41Z

@soumagne this seems like a better option for the change logs

#17063 (review)

…/daos-16501-part1

Integrate reviewers comments: - Restore Mercury Changelog Signed-off-by: Cedric Koch-Hofer <[email protected]>

Fix mercury release number Signed-off-by: Cedric Koch-Hofer <[email protected]>

knard38 · 2025-11-06T14:10:30Z

@soumagne this seems like a better option for the change logs

#17063 (review)

It seems that the integration of the changelog is not compatible as it with Mercury.
I am going to investigate.

soumagne · 2025-11-06T14:16:17Z

@soumagne this seems like a better option for the change logs
#17063 (review)

It seems that the integration of the changelog is not compatible as it with Mercury. I am going to investigate.

don't worry about it for now, maybe it's best that you wait that I merge my PR first that updates mercury to 2.4.1 first and includes your patch, I have also added the changeling there. See #16943

- Fix invalid date in mercury changelog - add verbose option to fpm to have meaningull error messages Signed-off-by: Cedric Koch-Hofer <[email protected]>

knard38 · 2025-11-06T14:45:20Z

@soumagne this seems like a better option for the change logs
#17063 (review)

It seems that the integration of the changelog is not compatible as it with Mercury. I am going to investigate.

don't worry about it for now, maybe it's best that you wait that I merge my PR first that updates mercury to 2.4.1 first and includes your patch, I have also added the changeling there. See #16943

I have fixed it: locally tested.
Also takes the opportunity to improve the fpm error messages.
I will wait after the merge of your PR.

DAOS-16501 build: Support of mercury with ASan

7fe6ec3

Instrument mercury with libasan according to build option SANITIZERS Signed-off-by: Cedric Koch-Hofer <[email protected]>

knard38 force-pushed the ckochhof/dev/master/daos-16501-part1 branch from 6646951 to 7fe6ec3 Compare October 8, 2025 05:08

knard38 marked this pull request as ready for review October 8, 2025 05:10

knard38 requested review from a team as code owners October 8, 2025 05:10

knard38 requested review from jolivier23 and soumagne October 8, 2025 05:10

knard38 self-assigned this Oct 8, 2025

knard38 requested a review from liw October 8, 2025 05:12

Merge remote-tracking branch 'origin/master' into ckochhof/dev/master…

c50d4ba

…/daos-16501-part1

liw previously approved these changes Oct 20, 2025

View reviewed changes

Merge remote-tracking branch 'origin/master' into ckochhof/dev/master…

e2b0d34

…/daos-16501-part1

knard38 added the enhancement label Oct 21, 2025

jolivier23 requested changes Oct 21, 2025

View reviewed changes

soumagne approved these changes Oct 21, 2025

View reviewed changes

soumagne requested changes Oct 21, 2025

View reviewed changes

kanard38 added 2 commits October 27, 2025 10:18

Merge remote-tracking branch 'origin/master' into ckochhof/dev/master…

1f118db

…/daos-16501-part1

DAOS-16501 build: Support of mercury with ASan

5cb9bbe

Integrate reviewers comments: - Fix CI integration - Use of official mercury patch 74dda4a Miscellaneous fixes related to package build. Signed-off-by: Cedric Koch-Hofer <[email protected]>

knard38 dismissed liw’s stale review via 5cb9bbe October 27, 2025 14:17

knard38 requested a review from a team as a code owner October 27, 2025 14:17

knard38 requested review from jolivier23, liw and soumagne October 27, 2025 14:20

soumagne reviewed Oct 27, 2025

View reviewed changes

Merge remote-tracking branch 'origin/master' into ckochhof/dev/master…

83387ea

…/daos-16501-part1

jolivier23 reviewed Oct 29, 2025

View reviewed changes

DAOS-16501 build: Support of mercury with ASan

8eb204a

Integrate reviewers comments: - Remove daos.spec update - Remove Debian packaging update Signed-off-by: Cedric Koch-Hofer <[email protected]>

knard38 requested review from jolivier23 and soumagne November 3, 2025 08:07

kanard38 added 3 commits November 6, 2025 09:10

Merge remote-tracking branch 'origin/master' into ckochhof/dev/master…

2a4c2fd

…/daos-16501-part1

DAOS-16501 build: Support of mercury with ASan

89f602f

Integrate reviewers comments: - Restore Mercury Changelog Signed-off-by: Cedric Koch-Hofer <[email protected]>

DAOS-16501 build: Support of mercury with ASan

967bc9f

Fix mercury release number Signed-off-by: Cedric Koch-Hofer <[email protected]>

DAOS-16501 build: Support of mercury with ASan

153c2b3

- Fix invalid date in mercury changelog - add verbose option to fpm to have meaningull error messages Signed-off-by: Cedric Koch-Hofer <[email protected]>

jolivier23 approved these changes Dec 18, 2025

View reviewed changes

DAOS-16501 build: Support of mercury with ASan #16917

Are you sure you want to change the base?

DAOS-16501 build: Support of mercury with ASan #16917

Uh oh!

Conversation

knard38 commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps for the author:

After all prior steps are complete:

Uh oh!

github-actions bot commented Sep 27, 2025

Uh oh!

daosbuild3 commented Sep 30, 2025

Uh oh!

daosbuild3 commented Oct 8, 2025

Uh oh!

daosbuild3 commented Oct 9, 2025

Uh oh!

daosbuild3 commented Oct 9, 2025

Uh oh!

daosbuild3 commented Oct 9, 2025

Uh oh!

daosbuild3 commented Oct 9, 2025

Uh oh!

daosbuild3 commented Oct 9, 2025

Uh oh!

jolivier23 left a comment

Choose a reason for hiding this comment

Uh oh!

soumagne left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soumagne commented Oct 24, 2025

Uh oh!

knard38 commented Oct 27, 2025

Uh oh!

knard38 commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

knard38 commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

knard38 commented Oct 27, 2025

Uh oh!

knard38 commented Oct 27, 2025

Uh oh!

soumagne Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knard38 Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knard38 Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knard38 Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knard38 Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

knard38 commented Sep 27, 2025 •

edited

Loading

soumagne left a comment •

edited

Loading

knard38 commented Oct 27, 2025 •

edited

Loading

knard38 commented Oct 27, 2025 •

edited

Loading

soumagne Oct 27, 2025 •

edited

Loading

knard38 Oct 30, 2025 •

edited

Loading

knard38 Nov 6, 2025 •

edited

Loading

knard38 Nov 6, 2025 •

edited

Loading

knard38 Oct 30, 2025 •

edited

Loading

knard38 commented Nov 6, 2025 •

edited

Loading