Skip to content

DAOS-18368 object: refine EC rotate enumeration minimum_nr and break … #17347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wangshilong wants to merge 1 commit into
base: release/2.6
Choose a base branch
from
Open

DAOS-18368 object: refine EC rotate enumeration minimum_nr and break … #17347

wangshilong wants to merge 1 commit into from
+6 −4

Conversation

@wangshilong
Copy link
Contributor

@wangshilong wangshilong commented Jan 7, 2026

…condition (#17336)

  • For EC parity rotate, set minimum_nr to data_tgt_nr + 1 instead of all EC targets. This ensures that, even with some shard failures, at least one shard can return 2 keys (KDs).
  • Make the enumeration break condition stricter: only break if num < minimum_nr, not <=, to avoid premature termination when the buffer is exactly full.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@wangshilong
DAOS-18368 object: refine EC rotate enumeration minimum_nr and break …
0184123 
…condition (#17336)

- For EC parity rotate, set minimum_nr to data_tgt_nr + 1 instead of all EC targets.
This ensures that, even with some shard failures, at least one shard can return 2 keys (KDs).
- Make the enumeration break condition stricter: only break if num < minimum_nr, not <=,
to avoid premature termination when the buffer is exactly full.

Signed-off-by: Xuezhao Liu <[email protected]>
Signed-off-by: Wang Shilong <[email protected]>
@wangshilong wangshilong requested review from a team as code owners January 7, 2026 01:57
@wangshilong wangshilong added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label Jan 7, 2026
@wangshilong wangshilong requested review from liuxuezhao and removed request for a team January 7, 2026 01:57
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Ticket title is 'Data corruption observed with master branch under MDonSSD environment.'
Status is 'In Progress'
Labels: 'md_on_ssd,scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-18368

@wangshilong wangshilong requested a review from NiuYawei January 7, 2026 01:57
@wangshilong wangshilong requested a review from a team January 9, 2026 09:34
@daltonbohning
Copy link
Contributor

daltonbohning commented Jan 9, 2026

DAOS-18368 does not have merge approval for 2.6

@daltonbohning daltonbohning removed the request for review from a team January 9, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liuxuezhao liuxuezhao liuxuezhao approved these changes

@NiuYawei NiuYawei NiuYawei approved these changes

Assignees

No one assigned

Labels

unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wangshilong @daltonbohning @liuxuezhao @NiuYawei