Skip to content

DAOS-18368 object: refine EC rotate enumeration minimum_nr and break … #17347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangshilong wants to merge 1 commit into
base: release/2.6
Choose a base branch
from
+6 −4
Open

DAOS-18368 object: refine EC rotate enumeration minimum_nr and break … #17347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/object/srv_obj_migrate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* (C) Copyright 2019-2024 Intel Corporation.
* (C) Copyright 2025 Hewlett Packard Enterprise Development LP
* (C) Copyright 2025-2026 Hewlett Packard Enterprise Development LP
*
* SPDX-License-Identifier: BSD-2-Clause-Patent
*/
Expand Down Expand Up @@ -2953,9 +2953,11 @@ migrate_one_epoch_object(daos_epoch_range_t *epr, struct migrate_pool_tls *tls,

if (daos_oclass_is_ec(&unpack_arg.oc_attr)) {
p_csum = NULL;
/* EC rotate needs to fetch from all shards */
/* EC rotate needs to fetch from all shards, at least with data_tgt_nr alive,
* at least one shard should get 2 KDs.
*/
if (obj_ec_parity_rotate_enabled_by_version(arg->oid.id_layout_ver))
minimum_nr = obj_ec_tgt_nr(&unpack_arg.oc_attr);
minimum_nr = obj_ec_data_tgt_nr(&unpack_arg.oc_attr) + 1;
else
minimum_nr = 2;
enum_flags |= DIOF_RECX_REVERSE;
Expand Down Expand Up @@ -3083,7 +3085,7 @@ migrate_one_epoch_object(daos_epoch_range_t *epr, struct migrate_pool_tls *tls,
}

/* Each object enumeration RPC will at least one OID */
if (num <= minimum_nr && (enum_flags & DIOF_TO_SPEC_GROUP)) {
if (num < minimum_nr && (enum_flags & DIOF_TO_SPEC_GROUP)) {
D_DEBUG(DB_REBUILD, "enumeration buffer %u empty"
DF_UOID"\n", num, DP_UOID(arg->oid));
break;
Expand Down
Loading