Skip to content

DAOS-17946 pool,cont: change default properties #17358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johannlombardi merged 2 commits into from
Jan 12, 2026
+9 −8
Merged

DAOS-17946 pool,cont: change default properties #17358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8f8cb4
DAOS-17946 pool,cont: change default properties
phender Jan 8, 2026
d6e74b5
Merge branch 'jlo/betterdefault' into hendersp/DAOS-17946
phender Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tests/ftest/util/test_utils_container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""
(C) Copyright 2018-2024 Intel Corporation.
(C) Copyright 2025 Hewlett Packard Enterprise Development LP
(C) Copyright 2025-2026 Hewlett Packard Enterprise Development LP

SPDX-License-Identifier: BSD-2-Clause-Patent
"""
Expand Down
10 changes: 5 additions & 5 deletions src/tests/ftest/util/test_utils_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""
(C) Copyright 2018-2024 Intel Corporation.
(C) Copyright 2025 Hewlett Packard Enterprise Development LP
(C) Copyright 2025-2026 Hewlett Packard Enterprise Development LP

SPDX-License-Identifier: BSD-2-Clause-Patent
"""
Expand Down Expand Up @@ -272,7 +272,7 @@ def __init__(self, context, dmg_command, label_generator=None, namespace=POOL_NA
self.gid = os.getegid()

self.mode = BasicParameter(None)
self.name = BasicParameter(None) # server group name
self.name = BasicParameter(None) # server group name
self.svcn = BasicParameter(None)
self.target_list = BasicParameter(None)
self.nranks = BasicParameter(None)
Expand All @@ -281,9 +281,9 @@ def __init__(self, context, dmg_command, label_generator=None, namespace=POOL_NA
self.mem_ratio = BasicParameter(None)
self.scm_size = BasicParameter(None)
self.nvme_size = BasicParameter(None)
self.prop_name = BasicParameter(None) # name of property to be set
self.prop_value = BasicParameter(None) # value of property
self.properties = BasicParameter("rd_fac:0,space_rb:0") # string of cs name:value
self.prop_name = BasicParameter(None) # name of property to be set
self.prop_value = BasicParameter(None) # value of property
self.properties = BasicParameter(None, "rd_fac:0,space_rb:0") # string of cs name:value
self.rebuild_timeout = BasicParameter(None)
self.pool_query_timeout = BasicParameter(None)
self.pool_query_delay = BasicParameter(None)
Expand Down
5 changes: 3 additions & 2 deletions utils/node_local_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"""Node local test (NLT).

(C) Copyright 2020-2024 Intel Corporation.
(C) Copyright 2025 Hewlett Packard Enterprise Development LP
(C) Copyright 2025-2026 Hewlett Packard Enterprise Development LP
(C) Copyright 2025 Google LLC
(C) Copyright 2025 Enakta Labs Ltd

Expand Down Expand Up @@ -1015,7 +1015,8 @@ def _make_pool(self):
else:
size = 1024 * 4

rc = self.run_dmg(['pool', 'create', 'NLT', '--scm-size', f'{size}M', '--properties', 'rd_fac:0,space_rb:0'])
rc = self.run_dmg(['pool', 'create', 'NLT', '--scm-size', f'{size}M', '--properties',
'rd_fac:0,space_rb:0'])
print(rc)
assert rc.returncode == 0
self.fetch_pools()
Expand Down
Loading