Enable dynamodb state store tests #4069
Open
+423
−541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-aliaga
force-pushed
the
dynamodb-aws-client-test
branch
5 times, most recently
from
d65568d to
a02aed5
Compare
|
/ok-to-test |
Components certification testCommit ref: a02aed5 ❌ Some certification tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Components conformance testCommit ref: a02aed5 ❌ Some conformance tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: a02aed5 |
MyMirelHub
approved these changes
Oct 22, 2025
|
fyi @mikeee I think you disabled them |
mikeee
previously approved these changes
Oct 22, 2025
|
Cheers for migrating the unit tests 👍 |
javier-aliaga
force-pushed
the
dynamodb-aws-client-test
branch
from
a02aed5 to
27a8928
Compare
|
/ok-to-test |
Components conformance testCommit ref: 27a8928 ❌ Some conformance tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 27a8928 |
Components certification testCommit ref: 27a8928 ❌ Some certification tests failedThese tests failed:
Additionally, some tests did not report a status:
|
|
/ok-to-test |
Components conformance testCommit ref: 3689394 ❌ Some conformance tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Components certification testCommit ref: 3689394 ❌ Some certification tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 3689394 |
javier-aliaga
force-pushed
the
dynamodb-aws-client-test
branch
from
3689394 to
e59cfe2
Compare
|
/ok-to-test |
Components conformance testCommit ref: 605eeac ❌ Some conformance tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Components certification testCommit ref: 605eeac ❌ Some certification tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 605eeac |
javier-aliaga
force-pushed
the
dynamodb-aws-client-test
branch
from
605eeac to
79e2518
Compare
|
/ok-to-test |
Components certification testCommit ref: 79e2518 ❌ Some certification tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Components conformance testCommit ref: 79e2518 ❌ Some conformance tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 79e2518 |
javier-aliaga
force-pushed
the
dynamodb-aws-client-test
branch
2 times, most recently
from
9ece7a9 to
8e9f571
Compare
|
/ok-to-test dynamo |
Components certification testCommit ref: b10d98b ❌ Some certification tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Components conformance testCommit ref: b10d98b ❌ Some conformance tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: b10d98b |
javier-aliaga
force-pushed
the
dynamodb-aws-client-test
branch
from
b10d98b to
51ac476
Compare
mikeee
requested changes
Oct 23, 2025
There was a problem hiding this comment.
This PR should solely implement the required unit tests and make minor changes to the component itself.
Bot changes are extraneous and I can see you're attempting to use the new functionality you're proposing with this PR. The workflow dispatch from the bot uses the script from the main branch and not this PR branch.
In addition, the reason for some of the test failures arise from the existing conf/cert tests in a poor state where the same resources are used to back these components. The complete suite must finish prior to running a new workflow dispatch.
Also another thing to keep in mind - changes affecting unit tests do not require running the workflow dispatch to trigger conformance/certification tests.
Sorry for such a long review process on what should be a relatively small change. Appreciate you keeping up with the comments :)
There was a problem hiding this comment.
These bot changes should not be included in this PR.
|
sorry @mikeee for the noise, but the certification tests are failing in master and I am trying to fix them, that is why you can see all this mess in different files https://github.com/dapr/components-contrib/actions/runs/17871335183/job/51069208077 Not sure it is because the update of v2 or not. I will clean up this PR and we can tackle the cert tests in a different one |
javier-aliaga
force-pushed
the
dynamodb-aws-client-test
branch
4 times, most recently
from
2841023 to
2dee3df
Compare
|
@mikeee it is ready for review again |
MyMirelHub
approved these changes
Oct 24, 2025
sicoyle
approved these changes
Oct 30, 2025
Signed-off-by: Javier Aliaga <[email protected]>
javier-aliaga
force-pushed
the
dynamodb-aws-client-test
branch
from
2dee3df to
b73b70a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dynamodb state store test where disabled as part of the release 1.16 because of the aws cli v2 upgrade.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.