Open
Conversation
Member
|
While debugging, I suggest adding new components not in src/python/gem5/ so you don't have to recompile each time. Once you're done debugging, you can then move to src/python/gem5/ to contribute upstream (if you want) |
powerjg
reviewed
Feb 2, 2022
| 8, | ||
| 64, | ||
| size=size, | ||
| ) No newline at end of file |
powerjg
reviewed
Feb 2, 2022
| 1, | ||
| 64, | ||
| size=size | ||
| ) No newline at end of file |
Member
|
Also, great job @mahyarsamani for setting up the memory in the standard library to be so easy to extend! |
powerjg
reviewed
Feb 3, 2022
| // add a very basic sanity check on the port to ensure the | ||
| // invisible buffer is not growing beyond reasonable limits | ||
| if (!_disableSanityCheck && transmitList.size() > 128) { | ||
| if (!_disableSanityCheck && transmitList.size() > 524288) { |
Member
There was a problem hiding this comment.
Rather than making a code change, you can disable the sanity check in a configuration.
|
|
||
| # Maximum routing table size for sanity checks | ||
| max_routing_table_size = Param.Int(512, "Max. routing table size") | ||
| max_routing_table_size = Param.Int(524288, "Max. routing table size") |
Member
There was a problem hiding this comment.
Why changing the code and not updating the config file?
Change-Id: I9320ee236f38785361d0be1642d2517e0bc28a5c
Change-Id: I4f300202fb19ccb4c16906252fc909cfe18be0e5
Change-Id: I675a32a5150c8c3a3ecc95a4280b9dc287548a07
Change-Id: I9bf07b4a94cbe6887b266a41477fd7d29d1e5f17
Change-Id: I915ea225a1a5507191acdeec226520f25d894df2
Change-Id: Idd9c3309131597e8ef00fd207b1727a775eddc35
Change-Id: I2e4ef23313f93e5eb5cd5304eaceea2e9c01fba1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.