introduce dt_gui_dialog_add and dt_gui_scroll_wrap#19118
Merged
TurboGit merged 1 commit intodarktable-org:masterfrom Sep 1, 2025
Merged
introduce dt_gui_dialog_add and dt_gui_scroll_wrap#19118TurboGit merged 1 commit intodarktable-org:masterfrom
TurboGit merged 1 commit intodarktable-org:masterfrom
Conversation
dterrahe
force-pushed
the
dt_gui_scroll_wrap
branch
from
962e773 to
8cae094
Compare
dterrahe
force-pushed
the
dt_gui_scroll_wrap
branch
from
8cae094 to
e4bc5ed
Compare
TurboGit
added
priority: high
TurboGit
approved these changes
Sep 1, 2025
Member
TurboGit
left a comment
TurboGit
left a comment
There was a problem hiding this comment.
Looks good, tested and seems ok. Thanks!
This was referenced Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a couple of helper macros replacing
gtk_container_addto make an eventual transition to gtk4 easier.For this PR, all ui elements set up in any of the files touched should be tested to make sure all widgets expand correctly (horizontally and/or vertically) as they did before. I only did spot checks.