-
Notifications
You must be signed in to change notification settings - Fork 108
Update filmic-rgb.md #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update filmic-rgb.md #742
Conversation
Updated references to changed defaults and changed the structure to the mid tone saturation controls to emphasize the newer v6 and 7 versions
|
|
||
| latitude | ||
| : The latitude is the range between the two nodes enclosing the central linear portion of the curve, expressed as a percentage of the dynamic range defined in the [_scene_](#scene) tab (white relative exposure minus black relative exposure). It is the luminance range that is remapped in priority, and it is remapped to the luminance interval defined by the contrast parameter. It is usually advisable to keep the latitude as large as possible, while avoiding clipping. If clipping is observed, you can compensate by either decreasing the latitude, shifting the latitude interval with the _shadow ↔ highlights balance_ parameter, or decreasing the contrast. | ||
| : The latitude is the range between the two nodes enclosing the central linear portion of the curve, expressed as a percentage of the dynamic range defined in the [_scene_](#scene) tab (white relative exposure minus black relative exposure). It is the luminance range that is remapped in priority, and it is remapped to the luminance interval defined by the contrast parameter. While it is set to 0 by default, it is usually advisable to keep the latitude as large as possible, while avoiding clipping. If clipping is observed, you can compensate by either decreasing the latitude, shifting the latitude interval with the _shadow ↔ highlights balance_ parameter, or decreasing the contrast. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not reviewed all of the text in the PR but this paragraph is the reason I haven't resolved that issue so far. The recommendation (keep the latitude large) comes from the original developer. But since he is also the person who changed the default value to 0, it's hard to justify keeping that recommendation. Unfortunately since he's stopped talking to anyone involved in darktable now, it's hard to resolve this contradiction or understand his reasoning for the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the least worst option might be to just remove reference to the recommendation altogether
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is a contradiction. I believe it makes sense to set the latitude as wide a possible to control the roll-off at the edges, but the default is set at zero so the user can decide the settings to use. At least, that's how I see it. Personally, I don't bother with latitude, so I'm ok with the change or to remove that discussion altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dave22152 do you want to make the above change and get this merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Mica, I am on board with making the change. I know Chris had concerns but I'm comfortable with the language.
BTW, I'll probably be able to re-engage with the documentation in January and February since I'll be spending more time at home this winter.
Happy New Year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Happy new year!
|
This pull request has not had any activity in the past 60 days and will be closed in 365 days if not updated. Please verify it has no conflicts with the master branch and rebase if needed. Please add a comment if you need help or give permission to other people to finish your work. |
|
I've just merged #826 which fixes up some of the same sections so you have some conflicts now. At this point, I might consider just creating my own change to incorporate the remainder of the stuff in this PR, just to clear the backlog (the filmic documentation has needed attention for a while) |
|
Ok. As I mentioned before, I’m dealing with some significant family issues right now so my time is limited for other things. But do let me know if there’s something you need me to do. Sent from my iPhoneOn Jan 26, 2026, at 2:41 PM, Chris Elston ***@***.***> wrote:elstoc left a comment (darktable-org/dtdocs#742)
I've just merged #826 which fixes up some of the same sections so you have some conflicts now. At this point, I might consider just creating my own change to incorporate the remainder of the stuff in this PR, just to clear the backlog (the filmic documentation has needed attention for a while)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This is in response to Document recent changes to filmic defaults, #527
I updated references to changed defaults and changed the structure to the mid tone saturation controls to emphasize the newer v6 and 7 versions
This is my first attempt at a Pull Request, so hopefully I did this correctly.