Update filmic defaults and controls #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
#742 also attempts to make some changes to some of the same documentation. On reflection I think this is probably closer to what I would have done, but it doesn't mention the change to the default latitude. I think I'll go ahead and merge this one and we can perhaps revisit latitude in another PR. Thanks! |
Contributor
Author
Thank you - I had not read other PR. |
Contributor
|
I'm just working on the remaining changes now |
Contributor
|
Further updates in a643b0f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to two darktable PRs: darktable-org/darktable#12882 and darktable-org/darktable#12887
Also relates to dtdocs issue: #527
Attempts to update the filmic doc page with changes to defaults and controls. It's quite a long page, and I don't think the PR comments mention all the changes. 🤞 I hope I caught enough of the changes, but let me know what you think.