Update for mirai 2.1.0 #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now errors for mirai attempting to set
daemons()on the same compute profile without an explicitdaemons(0)reset.Normally packages using mirai should not set daemons themselves as per https://mirai.r-lib.org/articles/mirai.html#using-mirai-in-a-package but the use in logger is known and explicitly excepted.
Hi @daroczig I was just checking through revdeps and I realise I should have submitted this to you sooner. It's a rather niche case I think - only applicable if 2 async appenders try to use the same namespace (not even sure that's 'valid'). Thanks!