Skip to content

Conversation

@shikokuchuo
Copy link
Contributor

It now errors for mirai attempting to set daemons() on the same compute profile without an explicit daemons(0) reset.

Normally packages using mirai should not set daemons themselves as per https://mirai.r-lib.org/articles/mirai.html#using-mirai-in-a-package but the use in logger is known and explicitly excepted.

Hi @daroczig I was just checking through revdeps and I realise I should have submitted this to you sooner. It's a rather niche case I think - only applicable if 2 async appenders try to use the same namespace (not even sure that's 'valid'). Thanks!

@daroczig
Copy link
Owner

daroczig commented Apr 3, 2025

Thanks a ton 🙇

That error looks odd on Windows:

Error: Error: package or namespace load failed for 'mirai' in library.dynam(lib, package, package.lib):
   DLL 'nanonext' not found: maybe not installed for this architecture?

Checking if that's related, but any insights are highly appreciated.

@shikokuchuo
Copy link
Contributor Author

shikokuchuo commented Apr 3, 2025

Thanks. That error is noted and I'll investigate that - but it's unrelated to the changes here (and would have happened anyway). So feel free to merge this, and I'll fix that on my end, or it might drop off once R4.5 is released. One or the other!

@daroczig
Copy link
Owner

daroczig commented Apr 3, 2025

Understood, thank you -- merging.

@daroczig daroczig merged commit e3de03f into daroczig:main Apr 3, 2025
13 of 14 checks passed
@shikokuchuo
Copy link
Contributor Author

shikokuchuo commented Apr 4, 2025

@daroczig this is now fixed in nanonext, so the error will go away when the next version's released. Or you can add r-lib.r-universe.dev to your repos for it to be gone immediately 😄

@daroczig
Copy link
Owner

daroczig commented Apr 4, 2025

Fantastic, thank you very much, @shikokuchuo🙇

@shikokuchuo shikokuchuo deleted the update-mirai branch April 5, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants