Skip to content

firehose: echo any error output from dependencies task on failure #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevmoo merged 3 commits into from
Feb 5, 2026
Merged

firehose: echo any error output from dependencies task on failure #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13a9ad9
firehose: echo any error output from dependencies task on failure
kevmoo Feb 5, 2026
2f30026
also fix lint causing other failures
kevmoo Feb 5, 2026
07ce7c2
trying to fix
kevmoo Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/health.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ on:
required: false
flutter_packages:
description: List of packages depending on Flutter.
default: "\"\""
default: ""
required: false
type: string
ignore_license:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/health_base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ on:
type: boolean
required: false
flutter_packages:
default: '""'
default: ""
required: false
type: string
ignore_license:
Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
${{ fromJSON('{"true":"--coverage_web","false":""}')[inputs.coverage_web] }} \
--fail_on ${{ inputs.fail_on }} \
--warn_on ${{ inputs.warn_on }} \
--flutter_packages ${{ inputs.flutter_packages }} \
--flutter_packages "${{ inputs.flutter_packages }}" \
--ignore_packages ${{ inputs.ignore_packages }} \
--ignore_license ${{ inputs.ignore_license }} \
--ignore_changelog ${{ inputs.ignore_changelog }} \
Expand Down
6 changes: 1 addition & 5 deletions pkgs/corpus/lib/pub.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,7 @@ class Pub {

for (;;) {
final targetUri = uri.replace(
queryParameters: {
'q': query,
'page': page.toString(),
if (sort != null) 'sort': sort,
},
queryParameters: {'q': query, 'page': page.toString(), 'sort': ?sort},
Copy link
Member Author

@kevmoo kevmoo Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed for CI to be green

);

final map = await _getJson(targetUri);
Expand Down
5 changes: 5 additions & 0 deletions pkgs/firehose/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.13.2-wip

- Echo any error output from dependencies task on failure
(avoids silent failures).

## 0.13.1

- Fix an issue with a nullable neededVersion
Expand Down
5 changes: 3 additions & 2 deletions pkgs/firehose/lib/src/health/health.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ class Health {
logStdout: false,
);

final (result, _, _) = runDashProcess(
final (result, out, err) = runDashProcess(
flutterPackages,
package,
[
Expand All @@ -219,7 +219,8 @@ class Health {

if (result.exitCode != 0) {
hasError = true;
final output = (result.stderr as String).replaceAll('\n', '<br>');
final output = (err.trim().isNotEmpty ? err.trim() : out.trim())
.replaceAll('\n', '<br>');
results.add('''
| ${package.name} | <details><summary>:exclamation: Show Issues</summary><pre>$output</pre></details> |''');
} else {
Expand Down
2 changes: 1 addition & 1 deletion pkgs/firehose/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: firehose
description: A tool to automate publishing of Pub packages from GitHub actions.
version: 0.13.1
version: 0.13.2-wip
repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose

environment:
Expand Down
2 changes: 1 addition & 1 deletion pkgs/firehose/test_data/golden/comment_unused-dependencies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
| :--- | :--- |
| package1 | :heavy_check_mark: All dependencies utilized correctly. |
| package2 | :heavy_check_mark: All dependencies utilized correctly. |
| package5 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br> * lints<br></pre></details> |
| package5 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br> * lints</pre></details> |

For details on how to fix these, see [dependency_validator](https://pub.dev/packages/dependency_validator).

Expand Down
4 changes: 2 additions & 2 deletions pkgs/firehose/test_data/golden/comment_unused-dependencies_healthchanged.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
| package1 | :heavy_check_mark: All dependencies utilized correctly. |
| package2 | :heavy_check_mark: All dependencies utilized correctly. |
| package3 | :heavy_check_mark: All dependencies utilized correctly. |
| package4 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br> * http<br> * intl<br> * lints<br> * path<br></pre></details> |
| package5 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br> * lints<br></pre></details> |
| package4 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br> * http<br> * intl<br> * lints<br> * path</pre></details> |
| package5 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br> * lints</pre></details> |

For details on how to fix these, see [dependency_validator](https://pub.dev/packages/dependency_validator).

Expand Down
2 changes: 1 addition & 1 deletion pkgs/firehose/test_data/golden/comment_unused-dependencies_ignore_package.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
| Package | Status |
| :--- | :--- |
| package2 | :heavy_check_mark: All dependencies utilized correctly. |
| package5 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br> * lints<br></pre></details> |
| package5 | <details><summary>:exclamation: Show Issues</summary><pre>These packages may be unused, or you may be using assets from these packages:<br> * lints</pre></details> |

For details on how to fix these, see [dependency_validator](https://pub.dev/packages/dependency_validator).

Expand Down
Loading