Skip to content

firehose: echo any error output from dependencies task on failure#393

Merged
kevmoo merged 3 commits intomainfrom
health_haxs
Feb 5, 2026
Merged

firehose: echo any error output from dependencies task on failure#393
kevmoo merged 3 commits intomainfrom
health_haxs

Conversation

@kevmoo
Copy link
Member

@kevmoo kevmoo commented Feb 5, 2026

Also fix health workflow to NOT install flutter unless it's needed

Fixes #392

Also fix health workflow to NOT install flutter unless it's needed

Fixes #392
@kevmoo kevmoo requested a review from mosuem as a code owner February 5, 2026 03:34
@github-actions github-actions bot added package:firehose type-infra A repository infrastructure change or enhancement labels Feb 5, 2026
'page': page.toString(),
if (sort != null) 'sort': sort,
},
queryParameters: {'q': query, 'page': page.toString(), 'sort': ?sort},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed for CI to be green

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

PR Health

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
firehose None 0.13.0 0.13.2-wip 0.13.2-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Unused Dependencies ✔️
Package Status
firehose ✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

Coverage ✔️
File Coverage
pkgs/firehose/lib/src/health/health.dart 💚 93 % ⬆️ 0 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@kevmoo kevmoo merged commit 289fd43 into main Feb 5, 2026
18 checks passed
@kevmoo kevmoo deleted the health_haxs branch February 5, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:corpus package:firehose type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firehose fails silently because it doesn't include stdout

2 participants