Synchronization logic for exported API #8203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
commented
Oct 29, 2024
isoos
reviewed
Oct 30, 2024
jonasfj
force-pushed
the
exported-api-draft-full-sync
branch
from
96be3e8 to
e069030
Compare
jonasfj
force-pushed
the
exported-api-draft-full-sync
branch
3 times, most recently
from
fb3a1f7 to
b7f7a99
Compare
isoos
reviewed
Nov 6, 2024
| // Only delete the item if it's older than _minGarbageAge | ||
| // This avoids any races where we delete files we've just created | ||
| // TODO: Conditionally deletion API from package:gcloud would be better! | ||
| await _bucket.tryDelete(item.name); |
Collaborator
There was a problem hiding this comment.
Nit: should we log the fact of deletion (here and elsewhere)? Maybe for a cursory later verification that we are not doing something stupid...
jonasfj
force-pushed
the
exported-api-draft-full-sync
branch
from
b7f7a99 to
55e624a
Compare
jonasfj
force-pushed
the
exported-api-draft-full-sync
branch
from
55e624a to
e722e19
Compare
jonasfj
changed the title
isoos
approved these changes
Nov 7, 2024
jonasfj
force-pushed
the
exported-api-draft-full-sync
branch
from
44a6479 to
51bb50d
Compare
isoos
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We identified 3 cases where we want to sync:
Package.updatedis changed.Leveraging the fact that
Bucket.listfrompackage:gcloudnow returnsObjectInfo, we can dosynchronizePackagesuch that it:TarballStorageand takes the versions visible in version listing and usessynchronizeTarballs.In the case where there is nothing to update, this should do:
Package,PackageVersionentities,md5Hash).bucket.listrequest to canonical bucket usingTarballStorage.bucket.listrequests to exported API bucket to confirm that archives exported match those fromTarballStorage.All in all, I think that's actually fairly efficient.