Change formatOutput function to accept a language version to parse with #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
approved these changes
Sep 10, 2024
munificent
approved these changes
Sep 10, 2024
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
…th (dart-lang/source_gen#718) Updates to the latest dart_style version and passes in a language version. This is in preparation for the tall style formatter which will require a language version to work properly. - This is a breaking change because the `formatOutput` callback now needs to accept a language version. - Also drops the default fix for single cascades, fixes will no longer be supported in dart_style.
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
…th (dart-lang/source_gen#718) Updates to the latest dart_style version and passes in a language version. This is in preparation for the tall style formatter which will require a language version to work properly. - This is a breaking change because the `formatOutput` callback now needs to accept a language version. - Also drops the default fix for single cascades, fixes will no longer be supported in dart_style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the latest dart_style version and passes in a language version. This is in preparation for the tall style formatter which will require a language version to work properly.
formatOutputcallback now needs to accept a language version.