Skip to content

[pubspec_parse] Replace pub run with dart run #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sigurdm wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[pubspec_parse] Replace pub run with dart run #2304

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e4de5c1
doc: replace pub run with dart run
sigurdm Jan 22, 2026
69f2df7
Add changelog entry for pubspec_parse
sigurdm Jan 22, 2026
a6b0718
Add changelog entries for all affected packages
sigurdm Jan 22, 2026
227898b
chore: revert changelog changes and use skip-changelog label instead
sigurdm Jan 22, 2026
6aff045
doc: replace pub run with dart run and dart test
sigurdm Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/file.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ jobs:
sdk: ${{ matrix.sdk }}

- run: dart pub get
- run: dart pub run test -j1
- run: dart run test -j1
2 changes: 1 addition & 1 deletion pkgs/coverage/test/test_files/main_test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkgs/pubspec_parse/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Read about `build.yaml` at https://pub.dev/packages/build_config
# To update generated code, run `pub run build_runner build`
# To update generated code, run `dart run build_runner build`
targets:
$default:
builders:
Expand Down
2 changes: 1 addition & 1 deletion pkgs/timing/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ print('${tracker.duration} ${tracker.innerDuration} ${tracker.slices}');
Use the following command to re-generate `lib/src/timing.g.dart` file:

```bash
dart pub run build_runner build
dart run build_runner build
```

## Publishing automation
Expand Down
2 changes: 1 addition & 1 deletion pkgs/yaml_edit/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Testing is done in two strategies: Unit testing (`/test/editor_test.dart`) and
Golden testing (`/test/golden_test.dart`). More information on Golden testing
and the input/output format can be found at `/test/testdata/README.md`.

These tests are automatically run with `pub run test`.
These tests are automatically run with `dart run test`.

## Limitations

Expand Down
4 changes: 2 additions & 2 deletions pkgs/yaml_edit/test/testdata/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ When the tests are run (see [Running Tests](#Running-Tests)), the series of spec

## Running Tests

By default, golden testing is performed with `pub run test`. If we only wanted to
performed golden testing, simply do: `pub run test test/golden_test.dart`.
By default, golden testing is performed with `dart run test`. If we only wanted to
performed golden testing, simply do: `dart run test test/golden_test.dart`.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a minor grammatical error in this sentence. It should be "...if we only wanted to perform..." instead of "...if we only wanted to performed...".

Suggested change
By default, golden testing is performed with `dart run test`. If we only wanted to
performed golden testing, simply do: `dart run test test/golden_test.dart`.
By default, golden testing is performed with `dart run test`. If we only wanted to
perform golden testing, simply do: `dart run test test/golden_test.dart`.

Copy link
Member

@lrhn lrhn Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and that just dart test test/golden_test.dart?

Copy link
Contributor Author

@sigurdm sigurdm Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


## Input Format

Expand Down
Loading