Skip to content

Conversation

devoncarew
Copy link
Member

  • update a call to the package:shelf_web_socket webSocketHandler() function

This code site returns a diagnostic when used with package:shelf_web_socket v3, and we need to roll both that version and this code into google3.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew devoncarew requested review from srujzs and nshahan August 1, 2025 14:49
@devoncarew
Copy link
Member Author

I don't know that the windows failures are related to this PR; I see bot failures for other recent PRs.

@nshahan
Copy link
Contributor

nshahan commented Aug 1, 2025

I don't know that the windows failures are related to this PR; I see bot failures for other recent PRs.

I agree, we have been investigating these flakes already.

@devoncarew devoncarew merged commit 4fc5d8c into main Aug 1, 2025
47 of 50 checks passed
@devoncarew devoncarew deleted the update_webSocketHandler branch August 1, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants