Skip to content

update a call to the package:shelf_web_socket webSocketHandler() function #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025
Merged

update a call to the package:shelf_web_socket webSocketHandler() function #2659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b6bff2
update a call to the package:shelf_web_socket webSocketHandler() func…
devoncarew Jul 31, 2025
bcaec1e
update pubspec version
devoncarew Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dwds/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 24.4.2-wip

- Update a call to the `package:shelf_web_socket` `webSocketHandler()` function.

## 24.4.1

- Implemented a WebSocket-based communication protocol that provides essential developer tooling (hot reload, service extensions) when Chrome debugger access is unavailable. - [#2605](https://github.com/dart-lang/webdev/issues/2605)
Expand Down
4 changes: 2 additions & 2 deletions dwds/lib/src/services/debug_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,11 +436,11 @@ class WebSocketDebugService implements DebugService {
}

/// Creates the WebSocket handler for incoming connections.
static dynamic _createWebSocketHandler(
static Handler _createWebSocketHandler(
ServiceExtensionRegistry serviceExtensionRegistry,
WebSocketProxyService webSocketProxyService,
) {
return webSocketHandler((WebSocketChannel webSocket) {
return webSocketHandler((WebSocketChannel webSocket, String? subprotocol) {
final responseController = StreamController<Map<String, Object?>>();
webSocket.sink.addStream(responseController.stream.map(jsonEncode));

Expand Down
2 changes: 1 addition & 1 deletion dwds/lib/src/version.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions dwds/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: dwds
# Every time this changes you need to run `dart run build_runner build`.
version: 24.4.1
version: 24.4.2-wip

description: >-
A service that proxies between the Chrome debug protocol and the Dart VM
Expand Down Expand Up @@ -29,7 +29,7 @@ dependencies:
shelf_packages_handler: ^3.0.0
shelf_proxy: ^1.0.4
shelf_static: ^1.1.0
shelf_web_socket: '>=1.0.0 <3.0.0'
shelf_web_socket: '>=2.0.0 <4.0.0'
source_maps: ^0.10.10
stack_trace: ^1.10.0
sse: ^4.1.2
Expand Down
Loading