[ DWDS ] Refactor AppInspector to support both Chrome and Web Socket connections
#2700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…connections Created two new subclasses of `AppInspector`: `ChromeAppInspector` and `WebSocketAppInspector`. Functionality that doesn't require knowledge of the specific DWDS connection mode (e.g., WIP vs WS) remains in the now abstract `AppInspector`, and functionality specific to the connection mode is now implemented in the respective `*AppInspector` subclass. This allows for sharing logic around maintaining caches for scripts and libraries.
bkonyi
changed the title
AppInspector to support both Chrome and Web Socket connections
bkonyi
force-pushed
the
refactor_app_inspector
branch
from
6109260 to
0fd4a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created two new subclasses of
AppInspector:ChromeAppInspectorandWebSocketAppInspector. Functionality that doesn't require knowledge of the specific DWDS connection mode (e.g., WIP vs WS) remains in the now abstractAppInspector, and functionality specific to the connection mode is now implemented in the respective*AppInspectorsubclass.This allows for sharing logic around maintaining caches for scripts and libraries.