Skip to content

Update pytest config key#396

Merged
m-albert merged 8 commits intodask:mainfrom
TomAugspurger:tom/pytest-config-fix
Apr 12, 2025
Merged

Update pytest config key#396
m-albert merged 8 commits intodask:mainfrom
TomAugspurger:tom/pytest-config-fix

Conversation

@TomAugspurger
Copy link
Member

In a pyproject.toml, pytest options go under tool.pytest.ini_options.

This should fix the warnings in the tests, like https://github.com/dask/dask-image/actions/runs/14005712747/job/39219300972#step:5:2350.

In a pyproject.toml, pytest options go under `tool.pytest.ini_options`.
@TomAugspurger
Copy link
Member Author

The CI failures are presumably because of the addopts = --flake8 now being honored. I haven't used that plugin before so I'm not sure what's going wrong.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tom! 🙏

@jakirkham
Copy link
Member

Could you please try updating pytest-flake8 to 1.3.0?

It is pinned in the environment files to an older version, which likely is incompatible with newer versions of flake8. For example:

@jakirkham
Copy link
Member

jakirkham commented Apr 7, 2025

Thanks Tom! 🙏

Looks like that fixed it

Can see flake8 is now running and raising legitimate errors that need fixes (like line length)

@jakirkham
Copy link
Member

Have pushed fixes for the flake8 errors that came up

@m-albert could you please review? 🙂

@TomAugspurger
Copy link
Member Author

Thanks for handling those!

Copy link
Collaborator

@m-albert m-albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me!

@m-albert
Copy link
Collaborator

Thanks Tom and John, the code is much more readable and prettier now :) Merging.

@m-albert m-albert merged commit 64ebe79 into dask:main Apr 12, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants