Skip to content

Added dask-image#39

Merged
TomAugspurger merged 2 commits intorapidsai:mainfrom
TomAugspurger:tom/feature/dask-image
Apr 14, 2025
Merged

Added dask-image#39
TomAugspurger merged 2 commits intorapidsai:mainfrom
TomAugspurger:tom/feature/dask-image

Conversation

@TomAugspurger
Copy link
Contributor

dask/dask-image#396 is fixing a minor issue upstream, so that we don't get warnings about unknown markers.

BTW, I currently see a failure locally:

_______________________________ test_cupy_imread _______________________________

tmp_path = PosixPath('/tmp/pytest-of-toaugspurger/pytest-241/test_cupy_imread0')

    @pytest.mark.cupy
    def test_cupy_imread(tmp_path):
        a = np.random.uniform(low=0.0, high=1.0, size=(1, 4, 3)).astype(np.float32)
    
        fn = str(tmp_path/"test.tiff")
        with tifffile.TiffWriter(fn) as fh:
            for i in range(len(a)):
>               fh.save(a[i])
E               AttributeError: 'TiffWriter' object has no attribute 'save'

packages/dask-image/tests/test_dask_image/test_imread/test_cupy_imread.py:17: AttributeError
=========================== short test summary info ============================
FAILED packages/dask-image/tests/test_dask_image/test_imread/test_cupy_imread.py::test_cupy_imread - AttributeError: 'TiffWriter' object has no attribute 'save'
=============== 1 failed, 141 passed, 2291 deselected in 11.51s ================

I haven't done any investigation to see if that's related.

cc @jakirkham.

Closes #38

@jakirkham
Copy link
Member

jakirkham commented Apr 7, 2025

Thanks Tom! 🙏

Looks like a breaking change in tifffile. Have raised as issue: dask/dask-image#397

Edit - Added a fix in PR: dask/dask-image#398 (now merged!)

@jakirkham
Copy link
Member

Also Tom caught some issues with flake8 tests being missed. Fixing that up in PR: dask/dask-image#396

@jakirkham
Copy link
Member

What updates should be made to the previous gpuCI content?

dask/dask-image#400

@jakirkham
Copy link
Member

Thanks again Tom for working on this! 🙏

Think we merged all of your upstream fixes.

What are the next steps here?

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Apr 14, 2025

I think we're ready. I'll merge this now and it should be picked up in the next run (~11 hours from now I think).

@TomAugspurger TomAugspurger merged commit 479a9bf into rapidsai:main Apr 14, 2025
1 check passed
@TomAugspurger TomAugspurger deleted the tom/feature/dask-image branch April 14, 2025 19:15
@jakirkham
Copy link
Member

Ok sounds good. Thanks Tom! 🙏

Please let us know how it goes 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing dask-image

2 participants