Use tifffile.TiffWriter's write method in test_cupy_imread#398
Merged
Use tifffile.TiffWriter's write method in test_cupy_imread#398
tifffile.TiffWriter's write method in test_cupy_imread#398Conversation
Recently `tifffile` removed the `save` method, which has been deprecated. Switch to the `write` method to fix it.
This was referenced Apr 7, 2025
Member
Author
|
@TomAugspurger could you please test this and let us know whether it fixes the issue you saw? |
Collaborator
|
Thanks @jakirkham 🙏 I probably missed this occurrence of |
Member
|
@jakirkham confirmed that |
Member
Author
|
Thanks Marvin and Tom! 🙏 No worries, Marvin. In fact Tom is helping us update to a newer GPU CI so this is covered there: rapidsai/dask-upstream-testing#39 Glad to hear this is passes Tom. In that case let's merge so we can get this fix in and move on to the next fix |
tifffile.TiffWriter's write methodtifffile.TiffWriter's write method in test_cupy_imread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #397
Recently
tifffileremoved thesavemethod, which has been deprecated. Switch to thewritemethod to fix it.