Skip to content

Use tifffile.TiffWriter's write method in test_cupy_imread#398

Merged
jakirkham merged 1 commit intodask:mainfrom
jakirkham:use_tf_write
Apr 8, 2025
Merged

Use tifffile.TiffWriter's write method in test_cupy_imread#398
jakirkham merged 1 commit intodask:mainfrom
jakirkham:use_tf_write

Conversation

@jakirkham
Copy link
Member

Fixes #397

Recently tifffile removed the save method, which has been deprecated. Switch to the write method to fix it.

Recently `tifffile` removed the `save` method, which has been
deprecated. Switch to the `write` method to fix it.
@jakirkham
Copy link
Member Author

@TomAugspurger could you please test this and let us know whether it fixes the issue you saw?

@m-albert
Copy link
Collaborator

m-albert commented Apr 8, 2025

Thanks @jakirkham 🙏

I probably missed this occurrence of TiffWriter.save because it's part of the cupy marked tests which I hadn't run.

@TomAugspurger
Copy link
Member

@jakirkham confirmed that dask-image/tests/test_dask_image/test_imread/test_cupy_imread.py::test_cupy_imread passes with this branch and tifffile==2025.3.30.

@jakirkham
Copy link
Member Author

Thanks Marvin and Tom! 🙏

No worries, Marvin. In fact Tom is helping us update to a newer GPU CI so this is covered there: rapidsai/dask-upstream-testing#39

Glad to hear this is passes Tom. In that case let's merge so we can get this fix in and move on to the next fix

@jakirkham jakirkham changed the title Use tifffile.TiffWriter's write method Use tifffile.TiffWriter's write method in test_cupy_imread Apr 8, 2025
@jakirkham jakirkham merged commit 458ac63 into dask:main Apr 8, 2025
17 checks passed
@jakirkham jakirkham deleted the use_tf_write branch April 8, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecated use of TiffWriter.save in tests

3 participants