KubeCluster.shutdown_on_close should be False when created from_name

[Matt711]

Closes #725 .

[jacobtomlinson]

Thanks for raising this. I wonder if we can somehow allow folks to specify these options if they really want to.

For example with this change a user wouldn't be able to do the following

cluster = KubeCluster.from_name("foo", shutdown_on_close=True)

[jacobtomlinson]

Pseudo code and probably wont pass linting. But we could use the dict pipe merge now that 3.9 is our minimum!

Suggested change

	return cls(
	name=name,
	create_mode=CreateMode.CONNECT_ONLY,
	shutdown_on_close=False,
	**kwargs,
	)
	defaults = {"create_mode": CreateMode.CONNECT_ONLY, "shutdown_on_close": False}
	kwargs = defaults | kwargs
	return cls(
	name=name,
	**kwargs,
	)

[jacobtomlinson]

Thanks for raising this. I wonder if we can somehow allow folks to specify these options if they really want to.

For example with this change a user wouldn't be able to do the following

cluster = KubeCluster.from_name("foo", shutdown_on_close=True)

[jacobtomlinson]

Looks like CI is passing here. Could I ask you to add/update a test to cover this functionality?

[jacobtomlinson]

Awesome thanks!

The first kr8s PR has landed with #721 so we can start using it 🎉.

I made some quick suggestions here that you should be able to use to swap them out.

[Matt711]

Awesome thanks!

The first kr8s PR has landed with #721 so we can start using it 🎉.

I made some quick suggestions here that you should be able to use to swap them out.

Sweet! thanks