Skip to content

KubeCluster.shutdown_on_close should be False when created from_name #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 13, 2023
Merged

KubeCluster.shutdown_on_close should be False when created from_name #727

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
818c6bc
KubeCluster.shutdown_on_close should be False when created from_name
Matt711 May 30, 2023
cec9b6a
Allow users to specify crete_mode and shutdown_on_close options
Matt711 Jun 8, 2023
41b3908
Merge remote-tracking branch 'upstream/main' into shutdown-on-close
Matt711 Jun 12, 2023
0ec5e47
Update cluster from_name test
Matt711 Jun 12, 2023
db24bf3
Forgot to add async arg
Matt711 Jun 12, 2023
45c6e51
async cm
Matt711 Jun 12, 2023
9829c9c
Merge remote-tracking branch 'upstream/main' into shutdown-on-close
Matt711 Jun 12, 2023
adf7b18
Update for kr8s PR
Matt711 Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dask_kubernetes/operator/kubecluster/kubecluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,7 +867,12 @@ def from_name(cls, name, **kwargs):
--------
>>> cluster = KubeCluster.from_name(name="simple-cluster")
"""
return cls(name=name, create_mode=CreateMode.CONNECT_ONLY, **kwargs)
return cls(
name=name,
create_mode=CreateMode.CONNECT_ONLY,
shutdown_on_close=False,
**kwargs,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pseudo code and probably wont pass linting. But we could use the dict pipe merge now that 3.9 is our minimum!

Suggested change
return cls(
name=name,
create_mode=CreateMode.CONNECT_ONLY,
shutdown_on_close=False,
**kwargs,
)
defaults = {"create_mode": CreateMode.CONNECT_ONLY, "shutdown_on_close": False}
kwargs = defaults | kwargs
return cls(
name=name,
**kwargs,
)



def make_cluster_spec(
Expand Down