Skip to content

Conversation

@pietern
Copy link
Contributor

@pietern pietern commented Dec 17, 2024

Changes

A small subset of tests trigger cluster creation to run jobs. These tests comprise a substantial amount of the total integration test runtime. We can skip them on PRs and only run them on the main branch.

Tests

Confirmed the short runtime is ~20 mins.

@pietern pietern force-pushed the skip-run-in-short-mode branch from 67ef984 to 9ffbdd1 Compare December 17, 2024 16:03
@pietern pietern marked this pull request as ready for review December 17, 2024 16:06
@github-actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 2024
  • Commit SHA: c695da385b516383e3bdde8ab9993be7f4d9cde0

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12376847010

@echo "✓ Filling vendor folder with library code ..."
@go mod vendor

INTEGRATION = gotestsum --format github-actions --rerun-fails --jsonfile output.json --packages "./integration/..." -- -parallel 4 -timeout=2h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-parallel 4

why did we set this, isn't it by default set to number of CPUs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, but we have 2 CPUs on the runners, so increased it a bit.

@pietern pietern enabled auto-merge December 17, 2024 16:36
@pietern pietern added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 23ddee8 Dec 17, 2024
10 checks passed
@pietern pietern deleted the skip-run-in-short-mode branch December 17, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants