Skip to content

Skip job runs during integration testing for PRs #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pietern merged 3 commits into from
Dec 17, 2024
Merged

Skip job runs during integration testing for PRs #2024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bb7042
Skip job runs during integration testing for PRs
pietern Dec 17, 2024
9ffbdd1
Add integration-short target
pietern Dec 17, 2024
c695da3
Merge branch 'main' into skip-run-in-short-mode
pietern Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@ vendor:
@echo "✓ Filling vendor folder with library code ..."
@go mod vendor

INTEGRATION = gotestsum --format github-actions --rerun-fails --jsonfile output.json --packages "./integration/..." -- -parallel 4 -timeout=2h
Copy link
Contributor

@denik denik Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-parallel 4

why did we set this, isn't it by default set to number of CPUs?

Copy link
Contributor Author

@pietern pietern Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, but we have 2 CPUs on the runners, so increased it a bit.


integration:
gotestsum --format github-actions --rerun-fails --jsonfile output.json --packages "./integration/..." -- -parallel 4 -timeout=2h
$(INTEGRATION)

integration-short:
$(INTEGRATION) -short

.PHONY: lint lintcheck test testonly coverage build snapshot vendor integration
.PHONY: lint lintcheck test testonly coverage build snapshot vendor integration integration-short
5 changes: 5 additions & 0 deletions integration/bundle/clusters_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ func TestDeployBundleWithCluster(t *testing.T) {
require.NoError(t, err)
require.NotNil(t, cluster)

if testing.Short() {
t.Log("Skip the job run in short mode")
return
}

out, err := runResource(t, ctx, root, "foo")
require.NoError(t, err)
require.Contains(t, out, "Hello World!")
Expand Down
5 changes: 5 additions & 0 deletions integration/bundle/python_wheel_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ func runPythonWheelTest(t *testing.T, templateName, sparkVersion string, pythonW
destroyBundle(t, ctx, bundleRoot)
})

if testing.Short() {
t.Log("Skip the job run in short mode")
return
}

out, err := runResource(t, ctx, bundleRoot, "some_other_job")
require.NoError(t, err)
require.Contains(t, out, "Hello from my func")
Expand Down
5 changes: 5 additions & 0 deletions integration/bundle/spark_jar_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ func runSparkJarTestCommon(t *testing.T, ctx context.Context, sparkVersion, arti
destroyBundle(t, ctx, bundleRoot)
})

if testing.Short() {
t.Log("Skip the job run in short mode")
return
}

out, err := runResource(t, ctx, bundleRoot, "jar_job")
require.NoError(t, err)
require.Contains(t, out, "Hello from Jar!")
Expand Down
Loading