internal: Convert deployplan.ActionType to int-based enum#3585
Merged
Conversation
- The order defines severity of action which will be used to decide final action for resource. - Add a new 'resize' action, will be useful when we add clusters.
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
approved these changes
Sep 10, 2025
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| type ActionType string | ||
| type ActionType int | ||
|
|
||
| // Actions are ordered in increasing severity. |
Contributor
There was a problem hiding this comment.
nit: After looking at https://github.com/databricks/cli/pull/3595/files, this should be priority, not severity.
denik
added a commit
that referenced
this pull request
Sep 11, 2025
…() (#3595) ## Changes New method FieldTriggers(), which is a more powerful version of RecreateFields() that allows associate any action with a field. Builds on top of #3585 ## Why This covers existing classification use cases without custom code. We might still need ClassifyChange function in the future, but exact types involved will likely change by that time (with regard to serialized plan work). ## Tests Existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
We will be able to decide on final action for the given resource as max(actions...), where actions come from local and remote comparison of individual fields.
Tests
Existing tests.