Fix migrate to store expanded globs in the new state #4068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
pietern
reviewed
Dec 3, 2025
| Building python_artifact... | ||
| update jobs.sample_job | ||
|
|
||
| Plan: 0 to add, 1 to change, 0 to delete, 1 unchanged |
Contributor
There was a problem hiding this comment.
It has 1 to change here. The intent is to make this 0 right?
Contributor
Author
There was a problem hiding this comment.
good catch, looking into this.
Contributor
Author
There was a problem hiding this comment.
We already have change even in terraform due to dynamic_version: #4074
There is also separate (pre-existing) issue with num_workers, will look into this in a follow up.
Collaborator
|
Commit: 26c3dd2
22 interesting tests: 13 flaky, 7 KNOWN, 2 SKIP
Top 49 slowest tests (at least 2 minutes):
|
pietern
approved these changes
Dec 3, 2025
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Can you include a "Badness"?
denik
force-pushed
the
denik/update-globs-after-build
branch
from
14cfe65 to
676a867
Compare
denik
force-pushed
the
denik/update-globs-after-build
branch
from
676a867 to
2a743aa
Compare
Collaborator
|
Commit: b4f3df3
36 interesting tests: 25 flaky, 7 KNOWN, 3 RECOVERED, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
github-actions bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
## Why Terraform only adds it if neither autoscale nor num_workers are not set. It filters it out if autoscale is set. ## Tests New acceptance test that has different configurations and asserts that requests are the same. Difference also disappears in existing tests: in default-python recorded requests now have no difference wrt num_workers. In migrate/default-python num_workers no longer triggers drift post migration #4068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since migrate includes phases.Build but not phases.DeployPrepare, it did not process globs.
I moved globs processing to phases.Build, they are logically related to artifact building.