-
Notifications
You must be signed in to change notification settings - Fork 125
Include old & new values for changes in the plan #4072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Commit: 667ce35
9 failing tests:
Top 20 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Dec 3, 2025
Collaborator
|
Commit: d576243
48 interesting tests: 31 FAIL, 8 flaky, 7 KNOWN, 1 SKIP, 1 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Useful for debugging. Could also be useful for resource implementation given that we pass PlanEntry to DoUpdate() now.
Note, "new" value is redundant because it comes from remote_state or new_state that is already included in the plan. But it could be still difficult for 3rd party tools to parse this out as it requires to support semantics of structpath (which includes things like
tasks[task_key='mytask']).On the other hand, "old" value is not redundant as we don't include prior state in the plan at the moment.